Updated Geant4 and dependencies clhep and vecgeom to use cxxstd= variant#10518
Updated Geant4 and dependencies clhep and vecgeom to use cxxstd= variant#10518gartung merged 24 commits intospack:developfrom
Conversation
…ant so that it is applied consistently.
gartung
force-pushed
the
geant4-clhep-update
branch
from
7d9563a to
d9f23aa
Compare
Sync with upstream PR spack#10518
…nstalled with geant4. This allows installing the data files are externals that can be common to many compiler version.
|
@drbenmorgan can you please add a review. |
| patch('cxx17_geant4_10_0.patch', level=1, when='@10.04.00: cxxstd=17') | ||
| depends_on("[email protected] cxxstd=17", when="@10.04 cxxstd=17") | ||
| depends_on("[email protected] cxxstd=17", when="@10.03.p03 cxxstd=17") | ||
| depends_on("vecgeom cxxstd=17", when="+vecgeom cxxstd=17") |
There was a problem hiding this comment.
With #10561 merged, and xerces-c always on, depends_on('xerces-c cxxstd=NN', when='cxxstd=NN') should be added for 11, 14 and 17.
|
@gartung only one minor suggestion in the Geant4 The data dependencies also look o.k., and definitely the way to go with this package. My only thought would be whether to split the data work into a separate PR for clarity/orthogonality, but I defer to Spack's policy here. One thing to look at would be introducing a Anyway, we can think about that later! |
|
@drbenmorgan the naming of the data packages follows the FNAL ups package names. This does not always match the Geant4 name. Do you think I should rename them? |
…ant (spack#10518) * Updated Geant4 and dependencies clhep and vecgeom to use cxxstd= variant so that it is applied consistently. * Make standalone geant4 data packages that are used when data is not installed with geant4. This allows installing the data files are externals that can be common to many compiler version. * move geant4 data package dependencies to umbrella package geant4-data Conflicts: var/spack/repos/builtin/packages/geant4/package.py
2 participants
so that it is applied consistently.