Added the py-alembic package as a pre-req for py-jupyterhub#10436
Merged
scheibelp merged 2 commits intospack:developfrom Feb 1, 2019
Merged
Added the py-alembic package as a pre-req for py-jupyterhub#10436scheibelp merged 2 commits intospack:developfrom
scheibelp merged 2 commits intospack:developfrom
Conversation
healther
reviewed
Jan 26, 2019
wspear
added a commit
to wspear/spack
that referenced
this pull request
Jan 28, 2019
…rash (spack#10441) which is merged and py-async-generator (spack#10439), py-prometheus-client (spack#10440) and py-alembic (spack#10436) which are pending as of this commit. This package depends on both python 3.5+ and node-js which depends on python 2.7/2.8 to build. Currently it can only be installed if the node-js package's python dependency is manually removed, so node-js will build with python found on the system rather than provided by spack. Upcoming commits may allow spack to reconcile this automatically. I have no prior experience with this program and have not tested it except to check for immedeiate and obvious build and runtime errors. Dependencies exercised by regular usage may not be included in this package.
ax3l
approved these changes
Jan 28, 2019
healther
approved these changes
Feb 1, 2019
Contributor
healther
left a comment
healther
left a comment
There was a problem hiding this comment.
You could have added both versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is up to snuff I'll add a couple more along similar lines before adding py-jupyterhub.