"setup" support with environments#10394
Closed
scheibelp wants to merge 2 commits intospack:developfrom
Closed
Conversation
…G to manage manually; update install/add commands with --setup option
Member
|
@scheibelp Thanks! Are you sure that the grammar in this PR can be merged? If so, I can take it from here... |
Member
Author
It doesn't change the schema so in that sense there is no issue. I wrote it to allow "upgrading" from the prior config format to the latter, but a test should also be added to confirm this. |
This comment has been minimized.
This comment has been minimized.
Member
Author
Fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7846
@citibeth this is intended to address:
But it is not complete: it only handles managing the configs and doesn't actually write the spconfig files etc. Depending on your time/preference, this can be folded into #7846 or I can add the rest of #7846 to this.
Allow user specs to store spec as well as a set of packages in the DAG to manage manually; update install/add commands with --setup option
This assumes that the
spack.yamlstored for environments maintains user specs either as(as before) or as
This follows the existing environment schema definition (which allows for strings or dictionaries).