Skip to content

"setup" support with environments#10394

Closed
scheibelp wants to merge 2 commits intospack:developfrom
scheibelp:features/setup-env-config
Closed

"setup" support with environments#10394
scheibelp wants to merge 2 commits intospack:developfrom
scheibelp:features/setup-env-config

Conversation

@scheibelp
Copy link
Copy Markdown
Member

See #7846

@citibeth this is intended to address:

At this point, a change to the grammar is required so the YAML files can accommodate Spack Setup functionality. I don't know how to change the grammar appropriately.

But it is not complete: it only handles managing the configs and doesn't actually write the spconfig files etc. Depending on your time/preference, this can be folded into #7846 or I can add the rest of #7846 to this.

Allow user specs to store spec as well as a set of packages in the DAG to manage manually; update install/add commands with --setup option

This assumes that the spack.yaml stored for environments maintains user specs either as

spack:
  specs:
    - py-numpy
    - openblas

(as before) or as

spack
  specs:
    - spec: py-numpy
      setup: [python]
    - spec: openblas
      setup: []

This follows the existing environment schema definition (which allows for strings or dictionaries).

…G to manage manually; update install/add commands with --setup option
@scheibelp scheibelp added the WIP label Jan 18, 2019
@citibeth
Copy link
Copy Markdown
Member

@scheibelp Thanks! Are you sure that the grammar in this PR can be merged? If so, I can take it from here...

@scheibelp
Copy link
Copy Markdown
Member Author

Are you sure that the grammar in this PR can be merged? If so, I can take it from here...

It doesn't change the schema so in that sense there is no issue.

I wrote it to allow "upgrading" from the prior config format to the latter, but a test should also be added to confirm this.

@scheibelp

This comment has been minimized.

@scheibelp
Copy link
Copy Markdown
Member Author

Let me sort out the CI failures: there's some issues with removing specs from environments.

Fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants