Skip to content

Exclude system mkl installs from numpy#10383

Merged
scheibelp merged 2 commits intospack:developfrom
scheibelp:bugfix/numpy-exclude-mkl
Jan 22, 2019
Merged

Exclude system mkl installs from numpy#10383
scheibelp merged 2 commits intospack:developfrom
scheibelp:bugfix/numpy-exclude-mkl

Conversation

@scheibelp
Copy link
Copy Markdown
Member

@scheibelp scheibelp commented Jan 17, 2019

Fixes #10361

When mkl isnt in the spec, still write an explicit mkl entry to prevent numpy from looking in system dirs; this is hacked in write now and needs some more finesse before merging

…nt numpy from looking in system dirs; this is hacked in write now and needs some more finesse before merging
@adamjstewart
Copy link
Copy Markdown
Member

@scheibelp This PR breaks the numexpr package when used with [email protected]:. numexpr calls the numpy config which reads site.cfg to determine where its libraries are located. As of [email protected], this no longer works. See pydata/numexpr#340 for the error message.

What should we do? Open a numpy issue? Revert the PR? Only apply the PR for older versions of numpy? Remove the empty sections of site.cfg post-installation?

@adamjstewart adamjstewart mentioned this pull request Jul 28, 2019
26 tasks
@scheibelp
Copy link
Copy Markdown
Member Author

@adamjstewart it looks like you have created an alternative solution to what was done here in #12170 (comment), specifically with

Fixes a bug where numpy would pick up the first BLAS/LAPACK it found, regardless of what was asked for (numpy/numpy#14146)

That's what this was going for, so it appears that at least for numpy 1.17.x and onward, the solution here is not required. It looks like https://github.com/numpy/numpy/pull/13132 was merged as of March 15 2019 so versions of numpy before 1.17.x may still benefit from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation issue: py-scipy

2 participants