Skip to content

omega-h: requires empty CMAKE_BUILD_TYPE#10297

Merged
tgamblin merged 1 commit intodevelopfrom
balay/fix-omega-h-cmake-buildtype
Jan 11, 2019
Merged

omega-h: requires empty CMAKE_BUILD_TYPE#10297
tgamblin merged 1 commit intodevelopfrom
balay/fix-omega-h-cmake-buildtype

Conversation

@balay
Copy link
Copy Markdown
Contributor

@balay balay commented Jan 9, 2019

@adamjstewart
Copy link
Copy Markdown
Member

@alalazo I tried something like this but it isn't allowed:

    variant('build_type', default='',                             
            description='The build type to build',                              
            values=('')) 

This current solution is kind of hacky (-DCMAKE_BUILD_TYPE is added twice and the second instance wins). It would be good to be able to support this, although I've never seen a CMake package that doesn't let you set this value to something.

@scottwittenburg scottwittenburg mentioned this pull request Jan 11, 2019
3 tasks
@tgamblin tgamblin merged commit 4cbeec0 into develop Jan 11, 2019
@balay balay deleted the balay/fix-omega-h-cmake-buildtype branch January 11, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in omega-h build due to c4521535e718ec9c0367b3825938dc06f1bc8aad

4 participants