Merged
Conversation
…terface not selected (following @adamjstewart advice)
…atible with cmake'FindPythonLibs module (at least how it is used in TFEL)
healther
previously requested changes
Jan 8, 2019
adamjstewart
approved these changes
Jan 8, 2019
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
A few minor comments, otherwise looks good!
| variant('fortran_bindings', default=True, | ||
| description='Enables fortran bindings') | ||
| variant('python_bindings', default=True, | ||
| description='Enables python bindings') |
Member
There was a problem hiding this comment.
I would be fine with dropping bindings from all of these variant names. It's usually implied. For example, most packages that add optional Python bindings just have a +python variant.
adamjstewart
reviewed
Jan 8, 2019
adamjstewart
dismissed
healther’s stale review
Requested change was implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MFrontGenericInterfaceSupportproject (MGIS) aims at proving tools (functions, classes, bindings, etc...) to handle behaviours written usingMFrontgeneric interface. For information aboutMFront, see http://tfel.sourceforge.net.MFrontis available inspackthrough theTFELpackage.Those tools are meant to be used by (
FEM,FFT, etc.) solver developers. Permissive licences have been chosen to allow integration in open-source and proprietary codes.