Skip to content

r-factominer: new versions#10263

Merged
adamjstewart merged 1 commit intospack:developfrom
odoublewen:update_r-factominer
Jan 8, 2019
Merged

r-factominer: new versions#10263
adamjstewart merged 1 commit intospack:developfrom
odoublewen:update_r-factominer

Conversation

@odoublewen
Copy link
Copy Markdown
Contributor

@odoublewen odoublewen commented Jan 7, 2019

Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason these dependencies were commented out is kind of complicated. See https://spack.readthedocs.io/en/latest/build_systems/rpackage.html#recommended-packages for the reasoning. The problem is that R by default comes with a set of recommended packages. If Spack installs these packages alongside R, and they are also listed as dependencies of an RPackage, Spack won't be able to activate that extension. I know the docs say that we add a --without-recommended-packages flag, but this isn't actually true, it was wishful thinking on my part. At some point, someone needs to add this flag to the r package and ensure that every other RPackage explicitly lists its recommended dependencies, like you're doing here. Anyway, I'm in favor of this change as I think it's a step in the right direction.

@adamjstewart adamjstewart merged commit 76dd4ca into spack:develop Jan 8, 2019
@odoublewen odoublewen deleted the update_r-factominer branch March 18, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants