Conversation
|
Looks like promises is a new requirement for 0.5, here's the relevant bit of the DESCRIPTION file from the 0.4 release. |
|
Ah. I'm going to remove 0.5 for now, since |
|
|
||
| depends_on('r-htmltools', type=('build', 'run')) | ||
| depends_on('r-htmlwidgets', type=('build', 'run')) | ||
| depends_on('r-htmltools@0.3.6:', type=('build', 'run')) |
There was a problem hiding this comment.
Do these tighter restrictions apply to all versions of dt, or just recent releases?
There was a problem hiding this comment.
I'm usually lazy and allow these kinds of tighter restrictions unless someone really does need an older version of the dependency. This is a common problem for Python and R packages, and I don't like to make people search backwards through every version to see when the dependency version was upgraded. But you are correct, it is more technically correct to list which version of r-dt require which versions of r-htmltools. If someone needs r-dt to build with an older version of r-htmltools, they are free to hack this package and submit a PR. In the meantime, I'm going to merge.
4 participants
depends_on()per https://cran.r-project.org/web/packages/DT/index.htmlQuestion: the CRAN page above says that
promisesis a dependency. But it was not previously in this package.py, andr-promisesdoesn't exist in spack. How is it possible that this worked before then?FYI @hartzell