Skip to content

spack buildcache: --allow_root -> --allow-root#10115

Merged
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:fixes/buildcache-flags
Dec 17, 2018
Merged

spack buildcache: --allow_root -> --allow-root#10115
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:fixes/buildcache-flags

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart commented Dec 15, 2018 •
edited
Loading

This specific flag for this specific command is the only one in Spack containing underscores. Since every Unix command I know of uses dashes, I switched it to dashes for conformity. No changes are needed for the Bash completion script, as the script already thinks it is --all-root.

@adamjstewart adamjstewart requested a review from gartung December 15, 2018 01:58
@adamjstewart adamjstewart merged commit d5d64bd into spack:develop Dec 17, 2018
@adamjstewart adamjstewart deleted the fixes/buildcache-flags branch December 17, 2018 19:02
tgamblin added a commit that referenced this pull request Dec 17, 2018
@tgamblin
Revert "spack buildcache: --allow_root -> --allow-root (#10115)"
bba4cf8 
This reverts commit d5d64bd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalazo alalazo alalazo approved these changes

@gartung gartung gartung approved these changes

+1 more reviewer

@healther healther healther approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildcache commands

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamjstewart @healther @alalazo @gartung