clp: add build_directory, remove old hack#10112
Merged
adamjstewart merged 2 commits intospack:developfrom Dec 18, 2018
Merged
Conversation
Contributor
Author
|
Don't merge yet -- seems it may still be broken. I'll open an issue if it persists. |
alalazo
approved these changes
Dec 18, 2018
adamjstewart
approved these changes
Dec 18, 2018
Member
|
@molecuul Apologies, browser didn't refresh in the last couple of hours 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10109 seemed to fix the build at first but later stopped working. I suspect this may be a bug in spack but adding build_directory has worked for another package
timewith the same issue.