Merged
Conversation
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Looks good, just a couple minor changes to make
Contributor
Author
|
Thanks! I updated the package accordingly |
adamjstewart
approved these changes
Dec 13, 2018
Member
|
Flake8 errors: |
Member
|
Ping @ohm314 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a spack package for RocksDB, a persistent key-value store for flash and RAM storage. We use the recommended Makefile build process and added variants for all the optional compression library dependencies.
Here's the project repo: https://github.com/facebook/rocksdb/
And here are their build instructions: https://github.com/facebook/rocksdb/blob/master/INSTALL.md