ENH: fixes and updates for openfoam-com build#10065
Merged
adamjstewart merged 1 commit intospack:developfrom Dec 17, 2018
Merged
ENH: fixes and updates for openfoam-com build#10065adamjstewart merged 1 commit intospack:developfrom
adamjstewart merged 1 commit intospack:developfrom
Conversation
olesenm
force-pushed
the
update-openfoam
branch
from
9502cda to
e870b0c
Compare
- previous removal of FOAM_EXT_LIBBIN (ThirdParty) from the environment during the build could lead to the system scotch library being found instead of the spack installation. Avoid this largely cosmetic change to the setting in favour of improved build robustness. These modifications will be largely superfluous in the 1812 release anyhow. - Split the patching algorithm into 'regular' and '@:1806' since the next versions of openfoam will again need fewer patches. - Add hook into foamCreateManpage to be used where available
Contributor
Author
|
@tgamblin @adamjstewart @junghans - if someone would care to take a review and merge action. The broken travis check seems to be unrelated to me |
Contributor
Author
|
@alalazo - could you see why the one build is stalled (and blocking everything)? All the others seem to be fine. |
adamjstewart
approved these changes
Dec 12, 2018
Contributor
Author
|
@adamjstewart Thank you Adam!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous removal of FOAM_EXT_LIBBIN (ThirdParty) from the environment
during the build could lead to the system scotch library being found
instead of the spack installation.
Avoid this largely cosmetic change to the setting in favour of
improved build robustness. These modifications will be largely
superfluous in the 1812 release anyhow.
Split the patching algorithm into 'regular' and '@:1806' since the
next versions of openfoam will again need fewer patches.
Add hook into foamCreateManpage to be used where available