Make downloads from list_url deterministic#10047
Merged
alalazo merged 1 commit intospack:developfrom Dec 10, 2018
Merged
Conversation
Merged
healther
approved these changes
Dec 7, 2018
Member
|
@adamjstewart Thanks for tracking this down! :-) |
michaelkuhn
approved these changes
Dec 8, 2018
alalazo
approved these changes
Dec 10, 2018
Member
|
@tgamblin @scheibelp FYI, this affects core (I merged straight away as it is a one-liner without evident side effects). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug discovered in #10025. For
cdo, the downloads page contains two types of links, one with/downloadin the path that downloads the tarball, and one without that brings you to a page with the same link. Currently,spack.util.web.find_versions_of_archivebehaves non-deterministically, and depending on which version of Python you use, you may get very different results:With this PR, Spack sorts the URLs before searching, meaning that the behavior is at least deterministic and the same across all versions of Python:
@michaelkuhn