gcc: Add patch to build GCC with glibc 2.28 and later#10046
Merged
scheibelp merged 1 commit intospack:developfrom Dec 8, 2018
Merged
gcc: Add patch to build GCC with glibc 2.28 and later#10046scheibelp merged 1 commit intospack:developfrom
scheibelp merged 1 commit intospack:developfrom
Conversation
adamjstewart
approved these changes
Dec 6, 2018
Member
|
Thanks! |
Member
|
Uh, the sys_ustat.h patch doesn't even apply cleanly to gcc 4.8 or 4.9 Anyway, I still care about building 4.8 and 4.9, so I'll submit a PR |
mwkrentel
added a commit
to mwkrentel/spack
that referenced
this pull request
Dec 11, 2018
The sys_ustat.h.patch to file sanitizer_platform_limits_posix.cc from PR spack#10046 does not apply cleanly to gcc 4.8 or 4.9 (or earlier). GCC up to 4.8.x either don't have libsanitizer or else don't include ustat.h in sanitizer_platform_limits_posix.cc. GCC 4.9.x includes ustat.h, but needs a slightly different patch. The patch applies to GCC 5.x up to 6.4, and 7.x up to 7.3 and also 8.1.0. The patch is already included in the tar files for gcc 6.5.0, 7.4.0 and 8.2.0.
adamjstewart
pushed a commit
that referenced
this pull request
Dec 12, 2018
The sys_ustat.h.patch to file sanitizer_platform_limits_posix.cc from PR #10046 does not apply cleanly to gcc 4.8 or 4.9 (or earlier). GCC up to 4.8.x either don't have libsanitizer or else don't include ustat.h in sanitizer_platform_limits_posix.cc. GCC 4.9.x includes ustat.h, but needs a slightly different patch. The patch applies to GCC 5.x up to 6.4, and 7.x up to 7.3 and also 8.1.0. The patch is already included in the tar files for gcc 6.5.0, 7.4.0 and 8.2.0.
Contributor
Author
|
Thanks for catching that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10035