Spades: Add version 3.13.0#10033
Merged
adamjstewart merged 2 commits intospack:developfrom Dec 7, 2018
Merged
Conversation
In version 3.13.0 the CmakeLists.txt dir is at a different location than in other versions. Versions up to 3.12.0 are located in "src" whereas 3.13.0 is a level deeper at "assemblers/src".
adamjstewart
reviewed
Dec 6, 2018
| homepage = "http://cab.spbu.ru/software/spades/" | ||
| url = "http://cab.spbu.ru/files/release3.10.1/SPAdes-3.10.1.tar.gz" | ||
|
|
||
| version('3.13.0', git='https://github.com/ablab/spades.git', tag='v3.13.0') |
Member
There was a problem hiding this comment.
Why switch to git? Also, you can add git as a top-level parameter like url now.
Member
Author
|
I updated the package. So I was pointed to the git instance by a fellow user but I now notice that there is a tarball available at the same original site. Makes the package much simpler now. |
adamjstewart
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 3.13.0 the CmakeLists.txt dir is at a different location than
in other versions. Versions up to 3.12.0 are located in "src" whereas
3.13.0 is a level deeper at "assemblers/src".