Merged
Conversation
Member
|
Are you sure something changed? For me, it correctly falls back on $ spack fetch cdo
==> Fetching https://code.mpimet.mpg.de/attachments/download/12760/cdo-1.9.5.tar.gz
curl: (22) The requested URL returned error: 404 Not Found
==> Fetching from https://code.mpimet.mpg.de/attachments/download/12760/cdo-1.9.5.tar.gz failed.
==> Fetching https://code.mpimet.mpg.de/attachments/download/18264/cdo-1.9.5.tar.gz
######################################################################## 100.0%Of course, I'm not opposed to explicitly specifying the URL since it saves the time of looking at the wrong location. |
Member
Author
|
Huh, strange. This is what happens for me: $ spack fetch cdo
==> Fetching https://code.mpimet.mpg.de/attachments/download/12760/cdo-1.9.5.tar.gz
curl: (22) The requested URL returned error: 404 Not Found
==> Fetching from https://code.mpimet.mpg.de/attachments/download/12760/cdo-1.9.5.tar.gz failed.
==> Fetching https://code.mpimet.mpg.de/attachments/18264/cdo-1.9.5.tar.gz
==> Warning: The contents of the archive look like HTML. Either the URL you are trying to use does not exist or you have an internet gateway issue. You can remove the bad archive using 'spack clean <package>', then try again using the correct URL.
==> Error: md5 checksum failed for .../cdo-1.9.5-ujq54kfqekw5pcjybm557fxa6sr6x2qw/cdo-1.9.5.tar.gz
Expected 0c60f2c94dc5c76421ecf363153a5043 but got 19f72e8ea96b05f7f1c97563f3e83bca(Note the missing |
Member
|
@michaelkuhn I uncovered the source of the discrepancy! Things work fine for me with Python 3, but I get the exact same error as you for Python 2. Let me try to track this down. We should still probably merge this PR, as it doesn't hurt, but I hate when Spack behaves differently for Python 2 and 3. |
Member
|
Hmm, maybe this is less of a Python 2 bug and more of a non-deterministic bug: $ python3 $(which spack) checksum cdo
==> Found 10 versions of cdo:
1.9.6rc4 https://code.mpimet.mpg.de/attachments/18911/cdo-1.9.6rc4.tar.gz
1.9.5 https://code.mpimet.mpg.de/attachments/download/18264/cdo-1.9.5.tar.gz
1.9.4 https://code.mpimet.mpg.de/attachments/download/17374/cdo-1.9.4.tar.gz
1.9.3 https://code.mpimet.mpg.de/attachments/download/16435/cdo-1.9.3.tar.gz
1.9.2 https://code.mpimet.mpg.de/attachments/download/16035/cdo-1.9.2.tar.gz
1.9.1 https://code.mpimet.mpg.de/attachments/15653/cdo-1.9.1.tar.gz
1.9.0 https://code.mpimet.mpg.de/attachments/15187/cdo-1.9.0.tar.gz
1.8.2 https://code.mpimet.mpg.de/attachments/download/14686/cdo-1.8.2.tar.gz
1.7.2 https://code.mpimet.mpg.de/attachments/download/12760/cdo-1.7.2.tar.gz
1.6.4 https://code.mpimet.mpg.de/attachments/8376/cdo-1.6.4.tar.gz
==> How many would you like to checksum? (default is 1, q to abort) q
==> Error: Aborted.
$ python2 $(which spack) checksum cdo
==> Found 10 versions of cdo:
1.9.6rc4 https://code.mpimet.mpg.de/attachments/18911/cdo-1.9.6rc4.tar.gz
1.9.5 https://code.mpimet.mpg.de/attachments/18264/cdo-1.9.5.tar.gz
1.9.4 https://code.mpimet.mpg.de/attachments/download/17374/cdo-1.9.4.tar.gz
1.9.3 https://code.mpimet.mpg.de/attachments/download/16435/cdo-1.9.3.tar.gz
1.9.2 https://code.mpimet.mpg.de/attachments/16035/cdo-1.9.2.tar.gz
1.9.1 https://code.mpimet.mpg.de/attachments/download/15653/cdo-1.9.1.tar.gz
1.9.0 https://code.mpimet.mpg.de/attachments/15187/cdo-1.9.0.tar.gz
1.8.2 https://code.mpimet.mpg.de/attachments/14686/cdo-1.8.2.tar.gz
1.7.2 https://code.mpimet.mpg.de/attachments/12760/cdo-1.7.2.tar.gz
1.6.4 https://code.mpimet.mpg.de/attachments/8376/cdo-1.6.4.tar.gz
==> How many would you like to checksum? (default is 1, q to abort) q
==> Error: Aborted.The problem is that the download page contains links with and without the |
Member
|
Fixed in #10047. I'll still merge this so that we don't have to rely on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how this ever worked but something seems to have changed so we now have to use the correct URLs.