Merged
Conversation
Fix the install of the single header amalgate in catch2.
scheibelp
reviewed
Dec 8, 2018
matz-e
pushed a commit
to BlueBrain/spack
that referenced
this pull request
Jun 12, 2019
Fix the install of the single header amalgate in catch2. The public API for catch < 2.3.0 was "#include <catch.hpp>". For 2.3.0+ it is "#include <catch2/catch.hpp>"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the install of the single header amalgate in catch2.
Thanks for @goxberry for noting the broken build! This PR is a simplified fix for the build issue reported in #9876.
Please be aware that the public API for catch <2.3.0 was
#include <catch.hpp>which is now for 2.3.0+#include <catch2/catch.hpp>: https://github.com/catchorg/Catch2/releases/tag/v2.3.0