Remove +fpic variant from packages #511
Description
If position-independent code is an option for a library, it should be controlled by a variant "+fpic"
I don't think this should ever be an option since it makes it incompatible with all shared libraries (including things like Python modules which have to be shared).
$ grep fpic `find . -name '*.py'`
./py-numpy/package.py: depends_on('netlib-blas+fpic', when='+blas')
./netlib-blas/package.py: variant('fpic', default=False, description="Build with -fpic compiler option")
./netlib-blas/package.py: if '+fpic' in self.spec:
./netlib-blas/package.py: mf.filter('^OPTS.*=.*', 'OPTS = -O2 -frecursive -fpic')
./netlib-blas/package.py: mf.filter('^CFLAGS =.*', 'CFLAGS = -O3 -fpic')
./trilinos/package.py: # Everything should be compiled with -fpic
./netlib-scalapack/package.py: variant('fpic', default=False, description="Build with -fpic compiler option")
./netlib-scalapack/package.py: if '+fpic' in spec: