Specifying un-needed dependency turns on default-False variant

### Steps to reproduce

When we turn on `+rocm` for GPU-enabled packages, we historically have also specified the core components of ROCm as dependencies directly on the spec, ie:
```
kokkos +rocm ^hip@6.4.1 ^hsa-rocr-dev@6.4.1 ^llvm-amdgpu@6.4.1
```

Now, we are using spack develop branch (commit e4641659) to test the `rocprofiler-systems` new Spackage, and we found that the `+tau` variant was getting turned on for some reason, even though it defaults to False and we didn't turn it on. After a lot of tracing, we found that `rocprofiler-systems` only depends on `hip`, so when we specify either `^hsa-rocr-dev` or `^llvm-amdgpu`, Spack turns on `+tau`, and Tau concretizes and uses `hsa-rocr-dev` and/or `llvm-amdgpu`. It seems that Spack changed variants in order to use all parts of the explicit spec.

Environment's spack.yaml is provided below. Uncomment the `^hsa-rocr-dev` to reproduce. You also have to edit the rocprofiler-systems spackage with the following:
```
diff --git a/repos/spack_repo/builtin/packages/rocprofiler_systems/package.py b/repos/spack_repo/builtin/packages/rocprofiler_systems/package.py
index 1a9b5374ff..dad2b57e4b 100644
--- a/repos/spack_repo/builtin/packages/rocprofiler_systems/package.py
+++ b/repos/spack_repo/builtin/packages/rocprofiler_systems/package.py
@@ -115,7 +115,8 @@ class RocprofilerSystems(CMakePackage):

     # hard dependencies
     depends_on("cmake@3.16:", type="build")
-    depends_on("dyninst@:12")
+    #depends_on("dyninst@:12")
+    depends_on("dyninst")
     depends_on("m4")
     depends_on("texinfo")
     depends_on("libunwind", type=("build", "run"))
```

[spack-rocprofiler-tau-bug.yaml.txt](https://github.com/user-attachments/files/21318993/spack-rocprofiler-tau-bug.yaml.txt)

### Error message

Incorrect concretization, `+tau` is turned on, even though default is False (if we add `^hsa-rocr-dev@6.4.1` to root spec):
```
==> Concretized 1 spec:
 -   2sp3d6k  rocprofiler-systems@6.4.1~caliper~ipo+mpi+mpi_headers+ompt+papi~perfetto_tools+python+rocm~strip+tau build_system=cmake build_type=Release commit=2e945e4a08781e13a822f568814e2c434fd8858f generator=make arch=linux-sles15-zen3 %c,cxx,fortran=gcc@13.2
 -   gz7bqrz      ^autoconf@2.72 build_system=autotools arch=linux-sles15-zen3
 -   5pc76uw          ^perl@5.40.0+cpanm+opcode+open+shared+threads build_system=generic arch=linux-sles15-zen3 %c=gcc@13.2
 -   d5rhy4q              ^berkeley-db@18.1.40+cxx~docs+stl build_system=autotools patches:=26090f4,b231fcc arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   hlwmwxi              ^bzip2@1.0.8~debug~pic+shared build_system=generic arch=linux-sles15-zen3 %c=gcc@13.2
 -   geio37r              ^gdbm@1.23 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   4dwudvo                  ^readline@8.2 build_system=autotools patches:=1ea4349,24f587b,3d9885e,5911a5b,622ba38,6c8adf8,758e2ec,79572ee,a177edc,bbf97f1,c7b45ff,e0013d9,e065038 arch=linux-sles15-zen3 %c=gcc@13.2
 -   baetttc      ^automake@1.16.5 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   rqi3vdp      ^cmake@3.31.8~doc+ncurses+ownlibs~qtgui build_system=generic build_type=Release arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   7a5uigz          ^curl@8.11.1~gssapi~ldap~libidn2~librtmp~libssh~libssh2+nghttp2 build_system=autotools libs:=shared,static tls:=openssl arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   hhxj5il              ^nghttp2@1.65.0 build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   xah2mr3              ^openssl@3.4.1~docs+shared build_system=generic certs=mozilla arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   ajp3zcw                  ^ca-certificates-mozilla@2025-05-20 build_system=generic arch=linux-sles15-zen3
 -   6b76ica              ^pkgconf@2.3.0 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   7qlw5zh          ^ncurses@6.5~symlinks+termlib abi=none build_system=autotools patches:=7a351bc arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   4xoljzn          ^zlib-ng@2.2.4+compat+new_strategies+opt+pic+shared build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   6mqj3ia      ^compiler-wrapper@1.0 build_system=generic arch=linux-sles15-zen3
[e]  5txpqaw      ^cray-mpich@8.1.31~cuda~rocm+wrappers build_system=generic arch=linux-sles15-zen3
 -   6zr2c2t      ^dyninst@13.0.0~ipo+openmp~stat_dysect~static build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   vyf6cij          ^boost@1.88.0+atomic~charconv+chrono~clanglibcpp~cobalt+container~context~contract~coroutine+date_time~debug+exception~fiber+filesystem~graph~graph_parallel~icu~iostreams~json~locale~log~math~mpi~mqtt5+multithreaded~nowide~numpy~pic~program_options~python+random~regex~serialization+shared~signals2~singlethreaded~stacktrace+system~taggedlayout~test+thread+timer~type_erasure~url~versionedlayout~wave build_system=generic cxxstd=11 patches:=a440f96 visibility=hidden arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   whd4yz2          ^elfutils@0.192~debuginfod+exeprefix+nls build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   k477yrs              ^libiconv@1.18 build_system=autotools libs:=shared,static arch=linux-sles15-zen3 %c=gcc@13.2
 -   2pj7wvj              ^xz@5.6.3~pic build_system=autotools libs:=shared,static arch=linux-sles15-zen3 %c=gcc@13.2
 -   wkufnnr              ^zstd@1.5.7+programs build_system=makefile compression:=none libs:=shared,static arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   avj6je5          ^intel-tbb@2022.0.0~ipo+shared+tm build_system=cmake build_type=Release cxxstd=default generator=make arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   rnnibme          ^libiberty@2.41+pic build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
[e]  k7rk2oa      ^gcc@13.2~binutils+bootstrap~graphite~mold~nvptx~piclibs~profiled~strip build_system=autotools build_type=RelWithDebInfo languages:='c,c++,fortran' arch=linux-sles15-zen3
 -   6zmv3s6      ^gcc-runtime@13.2 build_system=generic arch=linux-sles15-zen3
[e]  6hqoygt      ^glibc@2.38 build_system=autotools arch=linux-sles15-zen3
 -   kj2clk7      ^gmake@4.4.1~guile build_system=generic arch=linux-sles15-zen3 %c=gcc@13.2
[e]  dn2oioe      ^hip@6.4.1~asan~cuda+rocm build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3
 -   l4wxtzf      ^libtool@2.4.7 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   672cjn6          ^findutils@4.10.0 build_system=autotools patches:=440b954 arch=linux-sles15-zen3 %c=gcc@13.2
 -   ishtczr      ^libunwind@1.8.1~block_signals~conservative_checks~cxx_exceptions~debug~debug_frame+docs~pic+tests+weak_backtrace~xz~zlib build_system=autotools components:=none libs:=shared,static arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   5ha7co5      ^m4@1.4.20+sigsegv build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   l25thiv          ^diffutils@3.10 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   v2a3htm          ^libsigsegv@2.14 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   3oiiqzu      ^papi@7.1.0~cuda~debug+example~infiniband~lmsensors~nvml~powercap~rapl+rdpmc~rocm~rocm_smi~sde+shared~static_tools build_system=autotools patches:=48cb202 arch=linux-sles15-zen3 %c,cxx,fortran=gcc@13.2
[e]  hkpwrez      ^python@3.10.14+bz2+crypt+ctypes+dbm~debug+libxml2+lzma~optimizations+pic+pyexpat+pythoncmd+readline+shared+sqlite3+ssl~tkinter+uuid+zlib build_system=generic patches:=0d98e93,7d40923,ebdca64,f2fd060 arch=linux-sles15-zen3
 -   6oqwqdb      ^python-venv@1.0 build_system=generic arch=linux-sles15-zen3
[e]  cionnsz      ^rocm-smi-lib@6.4.1~asan+shared build_system=cmake build_type=Release generator=make patches:=62be726,9537cd7 arch=linux-sles15-zen3
[e]  dbkk6fc      ^rocprofiler-dev@6.4.1 build_system=cmake build_type=Release generator=make patches:=9f49746 arch=linux-sles15-zen3
[e]  hvmzkwm      ^rocprofiler-sdk@6.4.1 build_system=cmake build_type=Release commit=e8e49fe76971000a42a5a177d9a727d16dd0ebcf generator=make arch=linux-sles15-zen3
[e]  rbcbcka      ^roctracer-dev@6.4.1~asan~rocm build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3
 -   smfr3sy      ^tau@2.34.1~adios2+binutils~comm~craycnl~cuda~disable-no-pie~dyninst+elf+fortran~gasnet+io~level_zero+libdwarf+libunwind~mpi~ompt~opari~openacc~opencl~openmp+otf2+papi+pdt~phase~ppc64le~profileparam+pthreads~python+rocm+rocprofiler~rocprofiler-sdk~rocprofv2~roctracer~salt~scorep~shmem~sqlite~syscall~x86_64 build_system=generic arch=linux-sles15-zen3 %c,cxx,fortran=gcc@13.2
 -   famkxol          ^binutils@2.44~debuginfod~gas~gprofng+headers~interwork~ld+libiberty~lto~nls~pgo+plugins build_system=autotools compress_debug_sections=zlib libs:=shared,static arch=linux-sles15-zen3 %c,cxx=gcc@13.2
[e]  us244j4          ^hsa-rocr-dev@6.4.1~asan+image+shared build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3
 -   chm7itn          ^hwloc@2.11.1~cairo~cuda~gl~level_zero~libudev+libxml2~nvml~opencl+pci~rocm build_system=autotools libs:=shared,static arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   rykf7ba              ^libpciaccess@0.17 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   377dwve                  ^util-macros@1.20.1 build_system=autotools arch=linux-sles15-zen3
 -   6atdrgp              ^libxml2@2.13.5~http+pic~python+shared build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   jd5k3oa          ^libdwarf@2.0.0+decompression+dwarfdump~dwarfgen~examples~ipo+pic+shared build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   2a3wkuy          ^openjdk@17.0.11_9 build_system=generic certs=none arch=linux-sles15-zen3
 -   3lo5blc          ^otf2@3.1.1 build_system=autotools patches:=7e56d93 arch=linux-sles15-zen3 %c,cxx,fortran=gcc@13.2
 -   tise6a4          ^pdt@3.25.2~pic build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
[e]  5haj2ih          ^rocm-core@6.4.1~asan build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3
 -   qyhecsn      ^texinfo@7.1 build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   u54ggcl          ^gettext@0.23.1+bzip2+curses+git~libunistring+libxml2+pic+shared+tar+xz build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   x26jali              ^tar@1.35 build_system=autotools zip=pigz arch=linux-sles15-zen3 %c=gcc@13.2
 -   rsmihow                  ^pigz@2.8 build_system=makefile arch=linux-sles15-zen3 %c=gcc@13.2
```

Expected:
```
==> Concretized 1 spec:
 -   qpgcy6y  rocprofiler-systems@6.4.1~caliper~ipo+mpi+mpi_headers+ompt+papi~perfetto_tools+python+rocm~strip~tau build_system=cmake build_type=Release commit=2e945e4a08781e13a822f568814e2c434fd8858f generator=make arch=linux-sles15-zen3 %c,cxx,fortran=gcc@13.2
 -   gz7bqrz      ^autoconf@2.72 build_system=autotools arch=linux-sles15-zen3
 -   5pc76uw          ^perl@5.40.0+cpanm+opcode+open+shared+threads build_system=generic arch=linux-sles15-zen3 %c=gcc@13.2
 -   d5rhy4q              ^berkeley-db@18.1.40+cxx~docs+stl build_system=autotools patches:=26090f4,b231fcc arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   hlwmwxi              ^bzip2@1.0.8~debug~pic+shared build_system=generic arch=linux-sles15-zen3 %c=gcc@13.2
 -   geio37r              ^gdbm@1.23 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   4dwudvo                  ^readline@8.2 build_system=autotools patches:=1ea4349,24f587b,3d9885e,5911a5b,622ba38,6c8adf8,758e2ec,79572ee,a177edc,bbf97f1,c7b45ff,e0013d9,e065038 arch=linux-sles15-zen3 %c=gcc@13.2
 -   baetttc      ^automake@1.16.5 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   rqi3vdp      ^cmake@3.31.8~doc+ncurses+ownlibs~qtgui build_system=generic build_type=Release arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   7a5uigz          ^curl@8.11.1~gssapi~ldap~libidn2~librtmp~libssh~libssh2+nghttp2 build_system=autotools libs:=shared,static tls:=openssl arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   hhxj5il              ^nghttp2@1.65.0 build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   xah2mr3              ^openssl@3.4.1~docs+shared build_system=generic certs=mozilla arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   ajp3zcw                  ^ca-certificates-mozilla@2025-05-20 build_system=generic arch=linux-sles15-zen3
 -   6b76ica              ^pkgconf@2.3.0 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   7qlw5zh          ^ncurses@6.5~symlinks+termlib abi=none build_system=autotools patches:=7a351bc arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   4xoljzn          ^zlib-ng@2.2.4+compat+new_strategies+opt+pic+shared build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   6mqj3ia      ^compiler-wrapper@1.0 build_system=generic arch=linux-sles15-zen3
[e]  5txpqaw      ^cray-mpich@8.1.31~cuda~rocm+wrappers build_system=generic arch=linux-sles15-zen3
 -   6zr2c2t      ^dyninst@13.0.0~ipo+openmp~stat_dysect~static build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   vyf6cij          ^boost@1.88.0+atomic~charconv+chrono~clanglibcpp~cobalt+container~context~contract~coroutine+date_time~debug+exception~fiber+filesystem~graph~graph_parallel~icu~iostreams~json~locale~log~math~mpi~mqtt5+multithreaded~nowide~numpy~pic~program_options~python+random~regex~serialization+shared~signals2~singlethreaded~stacktrace+system~taggedlayout~test+thread+timer~type_erasure~url~versionedlayout~wave build_system=generic cxxstd=11 patches:=a440f96 visibility=hidden arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   whd4yz2          ^elfutils@0.192~debuginfod+exeprefix+nls build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   k477yrs              ^libiconv@1.18 build_system=autotools libs:=shared,static arch=linux-sles15-zen3 %c=gcc@13.2
 -   2pj7wvj              ^xz@5.6.3~pic build_system=autotools libs:=shared,static arch=linux-sles15-zen3 %c=gcc@13.2
 -   wkufnnr              ^zstd@1.5.7+programs build_system=makefile compression:=none libs:=shared,static arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   avj6je5          ^intel-tbb@2022.0.0~ipo+shared+tm build_system=cmake build_type=Release cxxstd=default generator=make arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   chm7itn              ^hwloc@2.11.1~cairo~cuda~gl~level_zero~libudev+libxml2~nvml~opencl+pci~rocm build_system=autotools libs:=shared,static arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   rykf7ba                  ^libpciaccess@0.17 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   377dwve                      ^util-macros@1.20.1 build_system=autotools arch=linux-sles15-zen3
 -   rnnibme          ^libiberty@2.41+pic build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
[e]  k7rk2oa      ^gcc@13.2~binutils+bootstrap~graphite~mold~nvptx~piclibs~profiled~strip build_system=autotools build_type=RelWithDebInfo languages:='c,c++,fortran' arch=linux-sles15-zen3
 -   6zmv3s6      ^gcc-runtime@13.2 build_system=generic arch=linux-sles15-zen3
[e]  6hqoygt      ^glibc@2.38 build_system=autotools arch=linux-sles15-zen3
 -   kj2clk7      ^gmake@4.4.1~guile build_system=generic arch=linux-sles15-zen3 %c=gcc@13.2
[e]  dn2oioe      ^hip@6.4.1~asan~cuda+rocm build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3
 -   l4wxtzf      ^libtool@2.4.7 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   672cjn6          ^findutils@4.10.0 build_system=autotools patches:=440b954 arch=linux-sles15-zen3 %c=gcc@13.2
 -   ishtczr      ^libunwind@1.8.1~block_signals~conservative_checks~cxx_exceptions~debug~debug_frame+docs~pic+tests+weak_backtrace~xz~zlib build_system=autotools components:=none libs:=shared,static arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   5ha7co5      ^m4@1.4.20+sigsegv build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   l25thiv          ^diffutils@3.10 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   v2a3htm          ^libsigsegv@2.14 build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   3oiiqzu      ^papi@7.1.0~cuda~debug+example~infiniband~lmsensors~nvml~powercap~rapl+rdpmc~rocm~rocm_smi~sde+shared~static_tools build_system=autotools patches:=48cb202 arch=linux-sles15-zen3 %c,cxx,fortran=gcc@13.2
[e]  hkpwrez      ^python@3.10.14+bz2+crypt+ctypes+dbm~debug+libxml2+lzma~optimizations+pic+pyexpat+pythoncmd+readline+shared+sqlite3+ssl~tkinter+uuid+zlib build_system=generic patches:=0d98e93,7d40923,ebdca64,f2fd060 arch=linux-sles15-zen3
 -   6oqwqdb      ^python-venv@1.0 build_system=generic arch=linux-sles15-zen3
[e]  cionnsz      ^rocm-smi-lib@6.4.1~asan+shared build_system=cmake build_type=Release generator=make patches:=62be726,9537cd7 arch=linux-sles15-zen3
[e]  dbkk6fc      ^rocprofiler-dev@6.4.1 build_system=cmake build_type=Release generator=make patches:=9f49746 arch=linux-sles15-zen3
[e]  hvmzkwm      ^rocprofiler-sdk@6.4.1 build_system=cmake build_type=Release commit=e8e49fe76971000a42a5a177d9a727d16dd0ebcf generator=make arch=linux-sles15-zen3
[e]  rbcbcka      ^roctracer-dev@6.4.1~asan~rocm build_system=cmake build_type=Release generator=make arch=linux-sles15-zen3
 -   qyhecsn      ^texinfo@7.1 build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   u54ggcl          ^gettext@0.23.1+bzip2+curses+git~libunistring+libxml2+pic+shared+tar+xz build_system=autotools arch=linux-sles15-zen3 %c,cxx=gcc@13.2
 -   6atdrgp              ^libxml2@2.13.5~http+pic~python+shared build_system=autotools arch=linux-sles15-zen3 %c=gcc@13.2
 -   x26jali              ^tar@1.35 build_system=autotools zip=pigz arch=linux-sles15-zen3 %c=gcc@13.2
 -   rsmihow                  ^pigz@2.8 build_system=makefile arch=linux-sles15-zen3 %c=gcc@13.2
```

### Information on your system

$ spack debug report
* **Spack:** 1.0.0.dev0 (https://github.com/spack/spack/commit/e46416596535ef0fcd8ecabdac36b0e332e82785)
* **Builtin repo:** https://github.com/spack/spack-packages/commit/c7152b7e3615bff9d3bef6a8d9c4decba4389589
* **Python:** 3.6.15
* **Platform:** linux-sles15-zen3

### General information

- [x] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [x] I have searched the issues of this repo and believe this is not a duplicate
- [x] I have run the failing commands in debug mode and reported the output

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Specifying un-needed dependency turns on default-False variant #51019

Steps to reproduce

Error message

Information on your system

General information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Specifying un-needed dependency turns on default-False variant #51019

Description

Steps to reproduce

Error message

Information on your system

General information

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions