Skip to content

spack.rewiring.rewire_node is broken on macOS #48262

@haampie

Description

@haampie

Steps to reproduce

spack.rewiring.rewire_node runs relocation code copied from binary_distribution.py, but doesn't contain later changes to the latter.

In particular codesign is not run on patched binaries, so they will not run on macos.

It should be refactored to use a common code path, so that it won't bit-rot again.

Information on your system

  • Spack: 0.24.0.dev0 (b78c517)
  • Python: 3.11.4
  • Platform: darwin-sequoia-m1

Metadata

Metadata

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions