Steps to reproduce

Run the following script:

from spack.spec import Spec

s = Spec("gmake~guile").concretized()
for _ in range(3):
    print(s.tree(hashes=True))
    print()
    s._mark_concrete(False)
    s._finalize_concretization()

The expected result would be to see 3 times the same hashes, since we use internal API to deconcretize a spec. The outcome is different though:

Error message

The issue is caused by a mixture of possibly wrong logic and caches. The first time we compute the hash we get the result we expect. In the following cases, when calling:

with value=False, we first clear the caches, then execute:

The first part of the issue is that this call recreates the caches we just deleted, via the Spec.installed property. It is not clear to me why we have:

or what this check even means.

When we recreate the hashes, we execute:

and that function does not enforce having a package_hash for hashes that need it:

Above we see that if an hash requires the package hash, but we don't have it, we simply skip adding it - which results in the wrong dict being used.

Information on your system

• Spack: 0.24.0.dev0 (f181ac1)
• Python: 3.13.0
• Platform: linux-ubuntu20.04-icelake

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have searched the issues of this repo and believe this is not a duplicate
• I have run the failing commands in debug mode and reported the output