-
Notifications
You must be signed in to change notification settings - Fork 2.4k
pkg.windows_establish_runtime_linkage() runs in the wrong place #42445
Copy link
Copy link
Closed
Description
Missed in review of #31930
The following
spack/lib/spack/spack/installer.py
Lines 1694 to 1697 in 9c4e44a
| # Currently this is how RPATH-like behavior is achieved on Windows, after install | |
| # establish runtime linkage via Windows Runtime link object | |
| # Note: this is a no-op on non Windows platforms | |
| pkg.windows_establish_runtime_linkage() |
is executed after post install hooks are run, but modifies files in the package's prefix.
That means it mutates the prefix after the write_install_manifest post install hook, which is wrong.
It should really itself be a post-install hook that runs before write_install_manifest.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done
Status
Done