Skip to content

pkg.windows_establish_runtime_linkage() runs in the wrong place #42445

@haampie

Description

@haampie

Missed in review of #31930

The following

# Currently this is how RPATH-like behavior is achieved on Windows, after install
# establish runtime linkage via Windows Runtime link object
# Note: this is a no-op on non Windows platforms
pkg.windows_establish_runtime_linkage()

is executed after post install hooks are run, but modifies files in the package's prefix.

That means it mutates the prefix after the write_install_manifest post install hook, which is wrong.

It should really itself be a post-install hook that runs before write_install_manifest.

Metadata

Metadata

Labels

Type

No type

Projects

Status

Done

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions