Steps to reproduce

$ spack compiler find

# duplicate one of the compiler entries and add a compiler flag to the higher priority instance

$ spack install foo

Error message

==> Error: {'--gcc-toolchain=/usr/tce/packages/gcc/gcc-8.3.1'} does not equal set()

Information on your system

@becker33 identified the problem: the compilers dictionary at the top of reorder_flags in asp.py is constructed incorrectly -- it leads to the lowest priority compiler of the same spec populating the dictionary instead of the highest priority one. This can probably be fixed as simply as reversing the order of the list from which the dictionary is constructed, but we should test to be sure.

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have searched the issues of this repo and believe this is not a duplicate
• I have run the failing commands in debug mode and reported the output