Installation issue: py-tensorflow

### Steps to reproduce the issue

```console
$ spack spec -I py-tensorflow

spack spec -I py-tensorflow
Input spec
--------------------------------
 -   py-tensorflow

Concretized
--------------------------------
 -   py-tensorflow@2.9.1%apple-clang@13.0.0~android~aws~computecpp~cuda~dynamic_kernels~gcp~gdr~hdfs~ignite~ios~jemalloc~kafka~mkl~monolithic~mpi~nccl~ngraph~numa~opencl~rocm~tensorrt~verbs~xla patches=2017b3e,3a839b1 arch=darwin-monterey-skylake
[+]      ^bazel@4.0.0%apple-clang@13.0.0+nodepfail patches=0f6940d,3e6448a,604423c,dbbf38b arch=darwin-monterey-skylake
[+]          ^openjdk@11.0.15_10%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]          ^python@3.9.13%apple-clang@13.0.0+bz2+ctypes+dbm~debug+ensurepip+libxml2+lzma~nis~optimizations+pic+pyexpat+pythoncmd+readline+shared+sqlite3+ssl~tix~tkinter~ucs4+uuid+zlib patches=0d98e93,4c24573,f2fd060 arch=darwin-monterey-skylake
[+]              ^apple-libuuid@1353.100.2%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]              ^bzip2@1.0.8%apple-clang@13.0.0~debug~pic+shared arch=darwin-monterey-skylake
[+]                  ^diffutils@3.8%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]                      ^libiconv@1.16%apple-clang@13.0.0 libs=shared,static arch=darwin-monterey-skylake
[+]              ^expat@2.4.8%apple-clang@13.0.0~libbsd arch=darwin-monterey-skylake
[+]              ^gdbm@1.19%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]                  ^readline@8.1%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]                      ^ncurses@6.2%apple-clang@13.0.0~symlinks+termlib abi=none arch=darwin-monterey-skylake
[+]                          ^pkgconf@1.8.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]              ^gettext@0.21%apple-clang@13.0.0+bzip2+curses+git~libunistring+libxml2+tar+xz arch=darwin-monterey-skylake
[+]                  ^libxml2@2.9.13%apple-clang@13.0.0~python arch=darwin-monterey-skylake
[+]                      ^xz@5.2.5%apple-clang@13.0.0~pic libs=shared,static arch=darwin-monterey-skylake
[+]                      ^zlib@1.2.12%apple-clang@13.0.0+optimize+pic+shared patches=0d38234 arch=darwin-monterey-skylake
[+]                  ^tar@1.30%apple-clang@13.0.0 zip=pigz arch=darwin-monterey-skylake
[+]                      ^pigz@2.7%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]              ^libffi@3.4.2%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]              ^openssl@1.1.1o%apple-clang@13.0.0~docs~shared certs=system arch=darwin-monterey-skylake
[+]                  ^perl@5.34.1%apple-clang@13.0.0+cpanm+shared+threads arch=darwin-monterey-skylake
[+]                      ^berkeley-db@18.1.40%apple-clang@13.0.0+cxx~docs+stl patches=b231fcc arch=darwin-monterey-skylake
[+]              ^sqlite@3.38.5%apple-clang@13.0.0+column_metadata+dynamic_extensions+fts~functions+rtree arch=darwin-monterey-skylake
[+]      ^flatbuffers@2.0.6%apple-clang@13.0.0~ipo+python+shared build_type=RelWithDebInfo arch=darwin-monterey-skylake
[+]          ^cmake@3.23.2%apple-clang@13.0.0~doc+ncurses+ownlibs~qt build_type=Release arch=darwin-monterey-skylake
[+]          ^py-pip@21.3.1%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]          ^py-setuptools@57.4.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]              ^py-wheel@0.37.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^hdf5@1.12.2%apple-clang@13.0.0~cxx~fortran+hl~ipo~java~mpi+shared~szip~threadsafe+tools api=default build_type=RelWithDebInfo arch=darwin-monterey-skylake
[+]      ^protobuf@3.17.3%apple-clang@13.0.0+shared build_type=Release arch=darwin-monterey-skylake
[+]      ^py-absl-py@0.13.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]          ^py-six@1.16.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]              ^py-setuptools@59.4.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-astunparse@1.6.3%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-gast@0.4.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-google-pasta@0.2.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-grpcio@1.43.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]          ^c-ares@1.15.0%apple-clang@13.0.0~ipo build_type=RelWithDebInfo arch=darwin-monterey-skylake
[+]          ^py-cython@0.29.30%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]          ^re2@2021-06-01%apple-clang@13.0.0~ipo+pic+shared build_type=RelWithDebInfo arch=darwin-monterey-skylake
[+]      ^py-h5py@3.6.0%apple-clang@13.0.0~mpi arch=darwin-monterey-skylake
[+]          ^py-numpy@1.22.4%apple-clang@13.0.0+blas+lapack patches=873745d arch=darwin-monterey-skylake
[+]              ^openblas@0.3.20%apple-clang@13.0.0~bignuma~consistent_fpcsr~ilp64+locking+pic+shared symbol_suffix=none threads=none arch=darwin-monterey-skylake
[+]          ^py-pkgconfig@1.5.5%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]              ^py-poetry-core@1.0.8%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-keras-preprocessing@1.1.2%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-libclang@11.1.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-opt-einsum@3.3.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-protobuf@3.20.1%apple-clang@13.0.0~cpp arch=darwin-monterey-skylake
[+]      ^py-termcolor@1.1.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-typing-extensions@4.1.1%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]          ^py-flit-core@3.6.0%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^py-wrapt@1.13.3%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]      ^swig@4.0.2%apple-clang@13.0.0 arch=darwin-monterey-skylake
[+]          ^pcre@8.45%apple-clang@13.0.0~jit+multibyte+utf arch=darwin-monterey-skylake
```


### Error message

<details><summary>Error message</summary><pre>
     40316      external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-
              assign -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG '-DNS_BLOCK_ASSERTIONS=1' '-std=c++11' -fdebug-compilation-d
              ir . -iquote . -iquote bazel-out/darwin-opt/bin -iquote external/com_google_protobuf -iquote bazel-out/darwin-opt/bin/external/com
              _google_protobuf -MD -MF bazel-out/darwin-opt/bin/tensorflow/stream_executor/_objs/dnn_proto_cc_impl/dnn.pb.d '-frandom-seed=bazel
              -out/darwin-opt/bin/tensorflow/stream_executor/_objs/dnn_proto_cc_impl/dnn.pb.o' -isysroot __BAZEL_XCODE_SDKROOT__ -F__BAZEL_XCODE
              _SDKROOT__/System/Library/Frameworks -F__BAZEL_XCODE_DEVELOPER_DIR__/Platforms/MacOSX.platform/Developer/Library/Frameworks '-mmac
              osx-version-min=12.1' -DGRPC_BAZEL_BUILD -w '-march=skylake' '-mtune=skylake' '-std=c++14' -Wno-unknown-warning-option -Wno-unused
              -but-set-variable -Wno-sign-compare -no-canonical-prefixes -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="
              redacted"' '-D__TIME__="redacted"' -c bazel-out/darwin-opt/bin/tensorflow/stream_executor/dnn.pb.cc -o bazel-out/darwin-opt/bin/te
              nsorflow/stream_executor/_objs/dnn_proto_cc_impl/dnn.pb.o)
     40317    Execution platform: @local_execution_config_platform//:platform
     40318    In file included from bazel-out/darwin-opt/bin/tensorflow/stream_executor/dnn.pb.cc:4:
  >> 40319    bazel-out/darwin-opt/bin/tensorflow/stream_executor/dnn.pb.h:10:10: fatal error: 'google/protobuf/port_def.inc' file not found
     40320    #include <google/protobuf/port_def.inc>
     40321             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     40322    1 error generated.
     40323    Target //tensorflow/tools/pip_package:build_pip_package failed to build
     40324    INFO: Elapsed time: 294.429s, Critical Path: 21.51s
     40325    INFO: 540 processes: 141 internal, 399 local.
  >> 40326    FAILED: Build did NOT complete successfully
  >> 40327    FAILED: Build did NOT complete successfully
</pre></details>


### Information on your system

```
* **Spack:** 0.19.0.dev0 (cfc46504ac64049df98e5876396a59ccf3deebf9)
* **Python:** 3.8.9
* **Platform:** darwin-monterey-skylake
* **Concretizer:** clingo
```

### Additional information

I've attached the requested files, along with various other files associated with the tensorflow build, including the `.bazelrc`. What appears to be happening is that the install path to the `protobuf` include files (which were installed correctly by `spack`) doesn't appear to be passed through to the compiler by `bazel`. A custom path to the include files is specified for linux in `package.py` and I've modified the package file to do the same for OSX (which I've attached here). I'm not sure how to proceed at this point (my suspicion is that this might be a `bagel/tensorflow` bug).

Mentioning the maintainers of `py-tensorflow`: @adamjstewart @aweits

[spack-build-01-configure-out.txt](https://github.com/spack/spack/files/8958108/spack-build-01-configure-out.txt)
[spack-build-02-build-out.txt](https://github.com/spack/spack/files/8958109/spack-build-02-build-out.txt)
[spack-build-env-mods.txt](https://github.com/spack/spack/files/8958110/spack-build-env-mods.txt)
[spack-build-env.txt](https://github.com/spack/spack/files/8958111/spack-build-env.txt)
[spack-build-out.txt](https://github.com/spack/spack/files/8958112/spack-build-out.txt)
[bazelrc.txt](https://github.com/spack/spack/files/8958120/bazelrc.txt)
[package.txt](https://github.com/spack/spack/files/8958124/package.txt)





### General information

- [X] I have run `spack debug report` and reported the version of Spack/Python/Platform
- [X] I have run `spack maintainers <name-of-the-package>` and **@mentioned** any maintainers
- [X] I have uploaded the build log and environment files
- [X] I have searched the issues of this repo and believe this is not a duplicate

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installation issue: py-tensorflow #31229

Steps to reproduce the issue

Error message

Information on your system

Additional information

General information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Installation issue: py-tensorflow #31229

Description

Steps to reproduce the issue

Error message

Information on your system

Additional information

General information

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions