Skip to content

Possible redundancy bug deriving spec hash? #30310

@vsoch

Description

@vsoch

I just saw this:

spack/lib/spack/spack/spec.py

Lines 4900 to 4903 in 83b9124

if 'build_spec' in node.keys():
node_hash = node[hash_type]
else:
node_hash = node[hash_type]

Should this be indexing something else if build_spec is found as a key? Or just nix the if and always look for that hash? It seems to do the same thing either way.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions