Skip to content

Rename all the arguments expecting a dependency type to "deptypes" #29397

@alalazo

Description

@alalazo

See discussion in #28673 (comment)

In Spack's codebase we have functions that take a deptype= argument, and other functions that take a deptypes= argument. This is confusing and might lead to typo and ultimately bug in the code. We need to standardize on one spelling.

These bugs have already been fixed in develop, but for instance we had a call:

for dep in self.spec.traverse(deptypes=('link', 'run')):

using deptypes= and expecting the other argument:

def traverse_edges(self, visited=None, d=0, deptype='all',

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions