Building findutils <= 4.7.0 fails after patch was added recently #28856
Description
Steps to reproduce
PR #28316 added a patch to the findutils package that is applied unconditionally. However, as noted by @kgerheiser, the file that is patched does not exist in earlier versions than 4.8.0. This causes build errors.
To reproduce:
spack install [email protected]
Error message
==> Installing findutils-4.7.0-h3fhihbyipvpkpyosc3v3bseblc4ak3s
==> No binary for findutils-4.7.0-h3fhihbyipvpkpyosc3v3bseblc4ak3s found: installing from source
/Users/heinzell/work/jedi-stack/spack-stack-new-joint/spack-stack-develop-20220209/spack/lib/spack/spack/target.py:137: UserWarning: microarchitecture specific optimizations are not supported yet on mixed compiler toolchains [check [email protected] for further details]
warnings.warn(msg.format(compiler))
The text leading up to this was:
--------------------------
|--- a/gl/lib/malloc/dynarray-skeleton.c
|+++ b/gl/lib/malloc/dynarray-skeleton.c
--------------------------
File to patch:
Skip this patch? [y]
1 out of 1 hunk ignored
==> Fetching https://mirror.spack.io/_source-cache/archive/c5/c5fefbdf9858f7e4feb86f036e1247a54c79fc2d8e4b7064d5aaa1f47dfa789a.tar.xz
==> Patch /Users/heinzell/work/jedi-stack/spack-stack-new-joint/spack-stack-develop-20220209/spack/var/spack/repos/builtin/packages/findutils/nonnull.patch failed.
==> Error: ProcessError: Command exited with status 1:
'/usr/bin/patch' '-s' '-p' '1' '-i' '/Users/heinzell/work/jedi-stack/spack-stack-new-joint/spack-stack-develop-20220209/spack/var/spack/repos/builtin/packages/findutils/nonnull.patch' '-d' '.'
Information on your system
* **Spack:** 0.17.1-1126-c5f0284d40
* **Python:** 3.9.10
* **Platform:** darwin-monterey-x86_64
* **Concretizer:** clingo
General information
- I have run
spack debug reportand reported the version of Spack/Python/Platform - I have searched the issues of this repo and believe this is not a duplicate
- I have run the failing commands in debug mode and reported the output