Skip to content

Patch naming conflicts #13788

@Paul-Ferrell

Description

@Paul-Ferrell

When a package defines a set of patches, if the name of the patch file (the last element of the URL) is the same across multiple patches they will clobber each other when fetched.

I'm a bit surprised this hasn't been found before, as Spack downloads all patches if you mirror even a single version.

Steps to reproduce the issue

# Check the mirror directory, and find only one copy of all_patches, when there should be 7. 
$ spack mirror -d <my_mirror> mpfr

### Errors
This causes spack to throw 'invalid hash' errors when trying to use these patches, as the patch downloaded first is the one available (rather than the version you happen to be trying to build).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions