wrap generator with collection to avoid exhausting it with single iteration (#5586)

scheibelp · becker33 · commit f53be46186ed · 2017-10-03T16:47:07.000-07:00
diff --git a/lib/spack/spack/build_environment.py b/lib/spack/spack/build_environment.py
@@ -191,9 +191,9 @@ def set_build_environment_variables(pkg, env, dirty):
         dirty (bool): Skip unsetting the user's environment settings
     """
     # Gather information about various types of dependencies
-    build_deps      = pkg.spec.dependencies(deptype=('build', 'test'))
-    link_deps       = pkg.spec.traverse(root=False, deptype=('link'))
-    build_link_deps = list(build_deps) + list(link_deps)
+    build_deps      = set(pkg.spec.dependencies(deptype=('build', 'test')))
+    link_deps       = set(pkg.spec.traverse(root=False, deptype=('link')))
+    build_link_deps = build_deps | link_deps
     rpath_deps      = get_rpath_deps(pkg)
 
     build_prefixes      = [dep.prefix for dep in build_deps]
