DependencySpec: prepare the object to store an arbitrary number of attributes

alalazo · alalazo · commit 98b98069df93 · 2023-01-18T15:35:47.000+01:00
diff --git a/lib/spack/spack/spec.py b/lib/spack/spack/spec.py
@@ -671,7 +671,7 @@ class DependencySpec:
         virtuals: virtual packages provided from child to parent node.
     """
 
-    __slots__ = "parent", "spec", "deptypes", "virtuals"
+    __slots__ = "parent", "spec", "parameters"
 
     def __init__(
         self,
@@ -683,28 +683,40 @@ def __init__(
     ):
         self.parent = parent
         self.spec = spec
-        self.deptypes = dp.canonical_deptype(deptypes)
-        self.virtuals = tuple(sorted(set(virtuals)))
+        self.parameters = {
+            "deptypes": dp.canonical_deptype(deptypes),
+            "virtuals": tuple(sorted(set(virtuals))),
+        }
 
-    def _update_edge_property(self, property_name: str, value: Tuple[str, ...]) -> bool:
-        current = getattr(self, property_name)
+    @property
+    def deptypes(self) -> Tuple[str, ...]:
+        return self.parameters["deptypes"]
+
+    @property
+    def virtuals(self) -> Tuple[str, ...]:
+        return self.parameters["virtuals"]
+
+    def _update_edge_multivalued_property(
+        self, property_name: str, value: Tuple[str, ...]
+    ) -> bool:
+        current = self.parameters[property_name]
         update = set(current) | set(value)
         update = tuple(sorted(update))
         changed = current != update
 
         if not changed:
             return False
 
-        setattr(self, property_name, update)
+        self.parameters[property_name] = update
         return True
 
     def update_deptypes(self, deptypes: Tuple[str, ...]) -> bool:
         """Update the current dependency types"""
-        return self._update_edge_property("deptypes", deptypes)
+        return self._update_edge_multivalued_property("deptypes", deptypes)
 
     def update_virtuals(self, virtuals: Tuple[str, ...]) -> bool:
         """Update the list of provided virtuals"""
-        return self._update_edge_property("virtuals", virtuals)
+        return self._update_edge_multivalued_property("virtuals", virtuals)
 
     def copy(self) -> "DependencySpec":
         """Return a copy of this edge"""
