Fixed issue with reindex and a failing unit test

alalazo · alalazo · commit 4181bc710a7e · 2020-05-08T16:25:55.000+02:00
diff --git a/lib/spack/spack/spec.py b/lib/spack/spack/spec.py
@@ -1789,7 +1789,9 @@ def read_yaml_dep_specs(dependency_dict):
             elif isinstance(elt, dict):
                 # new format: elements of dependency spec are keyed.
                 dag_hash, deptypes = elt['hash'], elt['type']
-                virtuals = elt['provides']
+                # {}.get instead of subscripting is needed for backward
+                # compatibility. Without it reindex would fail
+                virtuals = elt.get('provides', [])
             else:
                 raise spack.error.SpecError(
                     "Couldn't parse dependency types in spec.")
diff --git a/lib/spack/spack/test/installer.py b/lib/spack/spack/test/installer.py
@@ -190,7 +190,7 @@ def _spec(spec, force):
         spec = spack.spec.Spec('mpi').concretized()
         return {spec: None}
 
-    spec = spack.spec.Spec('intel-parallel-studio')
+    spec = spack.spec.Spec('mpich')
     spec.concretize()
 
     monkeypatch.setattr(spack.binary_distribution, 'get_spec', _spec)
