Skip to content

Remove pytest-openfiles, fix unit string comparison in doctests - #350

Merged
pllim merged 2 commits into
spacetelescope:masterfrom
pllim:fix-ci-20230314
Mar 14, 2023
Merged

pllim merged 2 commits into
spacetelescope:masterfrom
pllim:fix-ci-20230314

Conversation

@pllim

@pllim pllim commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

pllim added 2 commits March 14, 2023 09:23
and rely on ResourceWarning instead
that affected by new unit string ordering.
@github-actions

github-actions Bot commented Mar 14, 2023 •

Copy link
Copy Markdown

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@codecov

codecov Bot commented Mar 14, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6c2bd36) 97.09% compared to head (e50ef21) 97.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files          17       17           
  Lines        2030     2032    +2     
=======================================
+ Hits         1971     1973    +2     
  Misses         59       59           
Impacted Files Coverage Δ
synphot/blackbody.py 73.33% <100.00%> (+0.45%) ⬆️
synphot/specio.py 99.09% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
pllim merged commit 2e9032f into spacetelescope:master Mar 14, 2023
@pllim
pllim deleted the fix-ci-20230314 branch March 14, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ANN: Please migrate away from pytest-openfiles

1 participant