Skip to content

Bump min versions - #258

Merged
WilliamJamieson merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:bugfix/oldest
Aug 11, 2023
Merged

WilliamJamieson merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:bugfix/oldest

Conversation

@WilliamJamieson

@WilliamJamieson WilliamJamieson commented Aug 8, 2023 •

Copy link
Copy Markdown
Contributor

The oldest versions pins for roman_datamodels are currently broken. This is due to a breaking change in unit representations introduced in astropy/astropy#14439, which first appeared in astropy 5.3.0. So the min astropy version has been bumped to 5.3.0.

This necessitated an additional bump in numpy version at least 1.21. However, numpy 1.22 is the oldest supported version by numpy, so it makes sense to bump to 1.22.

Checklist

@WilliamJamieson
WilliamJamieson requested a review from a team as a code owner August 8, 2023 14:28
@codecov

codecov Bot commented Aug 8, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (0fababa) 96.56% compared to head (55b8cbb) 96.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   96.56%   96.67%   +0.11%     
==========================================
  Files          29       28       -1     
  Lines        2413     2406       -7     
==========================================
- Hits         2330     2326       -4     
+ Misses         83       80       -3     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim

pllim commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

This looks reasonable. 5.0.x is super old by now and getting dropped at the end of 2023.

@WilliamJamieson
WilliamJamieson merged commit 730dc42 into spacetelescope:main Aug 11, 2023
@WilliamJamieson
WilliamJamieson deleted the bugfix/oldest branch August 11, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants