solara standalone: default to host='localhost' and allow mult instances#3176
Merged
kecnry merged 3 commits intospacetelescope:mainfrom Sep 6, 2024
Merged
solara standalone: default to host='localhost' and allow mult instances#3176kecnry merged 3 commits intospacetelescope:mainfrom
kecnry merged 3 commits intospacetelescope:mainfrom
Conversation
kecnry
requested review from
bmorris3,
cshanahan1,
gibsongreen,
haticekaratay,
javerbukh,
pllim and
rosteen
as code owners
pllim
approved these changes
Aug 29, 2024
Contributor
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
Code looks reasonable, so LGTM as long as this works for @camipacifici . Thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3176 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.01%
==========================================
Files 124 124
Lines 18347 18349 +2
==========================================
Hits 16221 16221
- Misses 2126 2128 +2 ☔ View full report in Codecov by Sentry. |
kecnry
force-pushed
the
solara-localhost
branch
from
e5875e5 to
170f4d7
Compare
kecnry
changed the title
Member
Author
|
The port=0 default requires a release and bump in pin to solara.... marking as draft until then. |
kecnry
force-pushed
the
solara-localhost
branch
from
b44265a to
9646571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request defaults to using
host='localhost'when launching solara, but allowing the user to override from the CLI, and also uses an open port by default, allowing for multiple instances.The port=0 default requires a release and bump in pin to solara.... marking as draft until then.Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.