Repository navigation
TST: ignore sentinel deprecation warning from traitlets - #2456
Merged
Merged
Conversation
kecnry
force-pushed
the
ignore-sentinel-deprecation
branch
2 times, most recently
from
September 14, 2023 13:08
ebc4e63 to
45f4368
Compare
Contributor
|
That's not good. That repo has no activities the last 3 years. |
kecnry
force-pushed
the
ignore-sentinel-deprecation
branch
from
September 14, 2023 13:13
45f4368 to
43293b8
Compare
Member
Author
|
Right, although I suspect this was caused by a recent release of traitlets. It looks like they just raise their own deprecation warning on import? |
Contributor
No, the warning is from traittypes, not trailets.
|
pllim
reviewed
Sep 14, 2023
kecnry
force-pushed
the
ignore-sentinel-deprecation
branch
from
September 14, 2023 13:27
43293b8 to
77f54d3
Compare
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
kecnry
marked this pull request as ready for review
September 14, 2023 13:46
kecnry
requested review from
bmorris3,
cshanahan1,
haticekaratay,
javerbukh and
rosteen
as code owners
September 14, 2023 13:46
pllim
approved these changes
Sep 14, 2023
pllim
left a comment
Contributor
There was a problem hiding this comment.
The warning is worrisome but nothing we can do here. I reported it upstream. Thanks!
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Sep 14, 2023
…ning from traitlets
kecnry
added a commit
that referenced
this pull request
Sep 14, 2023
…tlets (#2457) Co-authored-by: Kyle Conroy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request ignores the deprecation warning from traitlets:
looks like bqplot imports traittypes, which has an
import *, which includes the lineEmpty = Sentinel('Empty', 'traittypes',which is triggering the deprecation warning 🤔Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.