Repository navigation
TST: Unit str compatibility with astropy 5.3 - #2077
Conversation
because str now reordered.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
==========================================
- Coverage 92.13% 92.12% -0.02%
==========================================
Files 140 140
Lines 15431 15444 +13
==========================================
+ Hits 14218 14228 +10
- Misses 1213 1216 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Tsk tsk dev failure now caused by ASDF but we cannot get rid of it until #2052 is merged. |
|
I need these gone so I can ponder #2052 properly, so I am just going to merge it. |
This comment was marked as resolved.
This comment was marked as resolved.
…ts-doctest TST: Unit str compatibility with astropy 5.3 (cherry picked from commit 60bb7e9)
| if ASTROPY_LT_5_3: | ||
| flux_unit_str = "erg / (Angstrom cm2 s)" | ||
| else: | ||
| flux_unit_str = "erg / (Angstrom s cm2)" |
There was a problem hiding this comment.
would this be useful moved to the top of the test or even somewhere that can be shared across tests?
There was a problem hiding this comment.
I don't think so. While they are the same now, nothing stops us from using data of different units for those tests going forward. It is not a requirement that those tests must all share the same flux unit. Just a coincidence.
Description
This pull request is to address upstream changes made by astropy/astropy#14439 so our dev job passes again.
Fix #2076
Blocked by:
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.