feat: change opacity of read items#996
Merged
Merged
Conversation
Contributor
Author
|
Result at 75% I don't expect this PR to be accepted as is, the integration can be greatly improved. |
spacecowboy
requested changes
Jan 27, 2026
spacecowboy
left a comment
spacecowboy
left a comment
Owner
There was a problem hiding this comment.
I think the change seems alright 👍
But the image ALSO has an alpha value set which depends on the read-state. And you change also affects it?
If so, could you remove the existing alpha setting on images in FeedItemCard and FeedItemCompactCard
Owner
|
Also apologies for the delay, I've been without computer |
Contributor
Author
|
Yes, it changes the opacity of the entire card. Removing it. |
spacecowboy
changed the title
jenningsloy318
added a commit
to jenningsloy318/Feeder
that referenced
this pull request
Mar 30, 2026
Incorporate upstream changes from master (v2.17.0, v2.18.0) while preserving all AI features developed on ai-features branch. Upstream features incorporated: - Paging mode with volume buttons and tap zones (spacecowboy#1062) - Home screen widget support (spacecowboy#1018) - Blocklist apply-to-summaries toggle (spacecowboy#1003) - AGP 9.0.0 + OkHttp 5.3.2 upgrade (spacecowboy#1051) - LazyColumn to Column migration for text selection crash fix (spacecowboy#1045) - Read item opacity (spacecowboy#996) - Bug fixes: sync deletion, compact layout scroll, network crash - 20+ language i18n updates via Weblate AI features preserved: - Multi-provider AI architecture (OpenAI + Anthropic) - Per-paragraph translation with circular progress - Mikepenz markdown rendering for summaries - Text selection menu customization - Summary/translation cancellation support Resolved 10 merge conflicts (3 HIGH, 3 MEDIUM, 4 LOW). Deleted superseded openai/ package and LeakCanary references. Re-indexed SettingsViewModel combine() params (35 total). Added mainActivityViewModel parameter to all 13 navigation destinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the opacity of the card at 75% when the article is read.
fix #379
The value can be discussed. I think 50% is too much, 75% may be not enough.
The alpha value can be defined somewhere else. However, I don't know if/how to move this modifier to Typography.
https://m3.material.io/styles/color/roles#63d6db08-59e2-4341-ac33-9509eefd9b4f Perhaps Color.kt?
I also experimented with a more generic approach by changing the alpha of the text in Typography.kt, but this doesn't change the opacity of the website logo. https://github.com/Jiogo18/Feeder/commit/afa8b57a599d3cdbc08a992ea0bd9e5cac2c41f5