feat: added suggested feeds to the Search UI by JaredTweed · Pull Request #964 · spacecowboy/Feeder

JaredTweed · 2025-10-28T17:39:09Z

This will just make building easier for a lot of people; incentivizing more people to contribute.

…uded script to check if feeds are working

spacecowboy · 2025-10-29T11:05:49Z

Please do not modify gradle build scripts. There are release automations that depend on it not changing.

Instead please describe what you see as an issue and I can advise you what needs to be changed to togher, or similar.

spacecowboy · 2025-10-29T11:11:13Z

Regarding the other changes

Could you post some screenshots of your changes
How did you come up with the suggestions in the list? How can it be reproduced?

JaredTweed · 2025-10-29T15:33:10Z

Please do not modify gradle build scripts. There are release automations that depend on it not changing.

Instead please describe what you see as an issue and I can advise you what needs to be changed to togher, or similar.

The build had two issues for me:

Hard-coded Java 17 toolchain fails on machines with only JDK 21
- kotlin { jvmToolchain(17) } enforces JDK 17. On Fedora 42 and newer macOS setups, the system default is JDK 21; Gradle then throws Cannot find a Java installation … matching languageVersion=17.
- In CI the legacy toolchain is present, but on contributor machines (including mine) it blocks any compose/AGP build until a second JDK is installed manually. I worked around it by picking max(17,
  currentJdkVersion).
Git commands break configuration-cache / sparse clones
- providers.exec { commandLine("git", …) } is invoked during configuration (lines 13–34/40 in tip-of-tree).
- When Gradle’s configuration cache is enabled—as Android Studio now does by default—the build aborts because configuration-time process execution is disallowed (Process 'command 'git'' finished with non-
  zero exit value 128).
- The same failure appears for users who fetch the source without git history (e.g., zip download or shallow checkout), where git describe/rev-list return 128.
- I added fallbacks (gitOutputOrNull, baseVersionCode/baseVersionName) to keep Play/F-Droid versioning working, but the underlying issue is that the build currently requires a full git repo and no
  configuration cache.

JaredTweed · 2025-10-29T15:38:17Z

Here is a screenshot, just click "Add feed", then start typing.

The suggested feeds list is in here: ./app/src/main/res/raw/suggested_feeds.json

and I expect the list to be continuously growing by other contributers. I just tried to do research to find all the available feeds I could. There is a python file in the same folder than cleans the list and automatically removes anything that is not a working feed.

…ut not the website

spacecowboy · 2025-10-30T15:42:56Z

Please do not modify gradle build scripts. There are release automations that depend on it not changing.
Instead please describe what you see as an issue and I can advise you what needs to be changed to togher, or similar.

The build had two issues for me:

1. Hard-coded Java 17 toolchain fails on machines with only JDK 21
   
   * kotlin { jvmToolchain(17) } enforces JDK 17. On Fedora 42 and newer macOS setups, the system default is JDK 21; Gradle then throws Cannot find a Java installation … matching languageVersion=17.
   * In CI the legacy toolchain is present, but on contributor machines (including mine) it blocks any compose/AGP build until a second JDK is installed manually. I worked around it by picking max(17,
     currentJdkVersion).

2. Git commands break configuration-cache / sparse clones
   
   * providers.exec { commandLine("git", …) } is invoked during configuration (lines 13–34/40 in tip-of-tree).
   * When Gradle’s configuration cache is enabled—as Android Studio now does by default—the build aborts because configuration-time process execution is disallowed (Process 'command 'git'' finished with non-
     zero exit value 128).
   * The same failure appears for users who fetch the source without git history (e.g., zip download or shallow checkout), where git describe/rev-list return 128.
   * I added fallbacks (gitOutputOrNull, baseVersionCode/baseVersionName) to keep Play/F-Droid versioning working, but the underlying issue is that the build currently requires a full git repo and no
     configuration cache.

Configuration cache works fine for me. The problem for you is that git returned a failure.

My main complaint is that you added baseVersionCode/baseVersionName, which by definition will be out of date, which can introduce silent failures in the release pipeline.

There are already correct values present:

        versionCode = 3813
        versionName = "2.15.1"

The release pipeline knows to how to find these lines and bump them.

The commitCount value is evaluated lazily. So you should not have any problem unless you try to build the play variant. Building the debug flavor (or f-droid) should never invoke git.

spacecowboy · 2025-10-30T15:45:21Z

As for the feature itself, I have considered something like it for a long time. But each entry needs to be vetted (by me presumably), so we don't end up with a bunch of nazi feeds or such.

spacecowboy · 2025-10-30T15:46:06Z

I'm fine you with fixing the java toolchain stuff

JaredTweed · 2025-10-30T15:46:51Z

As for the feature itself, I have considered something like it for a long time. But each entry needs to be vetted (by me presumably), so we don't end up with a bunch of nazi feeds or such.

Great! I am actually currently scraping all the feeds from sidestack, and we can just make sure it includes all the feeds with greater than 1000 subscribers.

JaredTweed · 2025-10-30T15:48:01Z

Please do not modify gradle build scripts. There are release automations that depend on it not changing.
Instead please describe what you see as an issue and I can advise you what needs to be changed to togher, or similar.

The build had two issues for me:
1. Hard-coded Java 17 toolchain fails on machines with only JDK 21
   
   * kotlin { jvmToolchain(17) } enforces JDK 17. On Fedora 42 and newer macOS setups, the system default is JDK 21; Gradle then throws Cannot find a Java installation … matching languageVersion=17.
   * In CI the legacy toolchain is present, but on contributor machines (including mine) it blocks any compose/AGP build until a second JDK is installed manually. I worked around it by picking max(17,
     currentJdkVersion).

2. Git commands break configuration-cache / sparse clones
   
   * providers.exec { commandLine("git", …) } is invoked during configuration (lines 13–34/40 in tip-of-tree).
   * When Gradle’s configuration cache is enabled—as Android Studio now does by default—the build aborts because configuration-time process execution is disallowed (Process 'command 'git'' finished with non-
     zero exit value 128).
   * The same failure appears for users who fetch the source without git history (e.g., zip download or shallow checkout), where git describe/rev-list return 128.
   * I added fallbacks (gitOutputOrNull, baseVersionCode/baseVersionName) to keep Play/F-Droid versioning working, but the underlying issue is that the build currently requires a full git repo and no
     configuration cache.
Configuration cache works fine for me. The problem for you is that git returned a failure.

My main complaint is that you added baseVersionCode/baseVersionName, which by definition will be out of date, which can introduce silent failures in the release pipeline.

There are already correct values present:
        versionCode = 3813
        versionName = "2.15.1"
The release pipeline knows to how to find these lines and bump them.

The commitCount value is evaluated lazily. So you should not have any problem unless you try to build the play variant. Building the debug flavor (or f-droid) should never invoke git.

Oh, okay, I will try building again, with just that java fix, and see if that can work on my computer easily. That was the largest issue for me.

JaredTweed · 2025-10-31T05:55:48Z

I think the feature is complete. Let me know if there is anything else to be added. By the way, I created this repo here to scrape the substacks: https://github.com/JaredTweed/sidestack_scraper

JaredTweed · 2025-10-31T17:23:03Z

I made the changes as minimal as possible to the build file as I could, and now it builds without any issues.

…y check if it matches the <feed> part during seach

spacecowboy · 2025-11-02T09:43:52Z

There are lint errors. Could you run ./gradlew ktlintformat please

spacecowboy

Just some small comments. I've tested it and I think it is good enough for a first version of the feature

spacecowboy · 2025-11-02T10:04:14Z

 }

 val latestTag by project.extra {
+    if (!file(".git").exists()) return@extra "unknown"


This is not the git command which is giving you the error. latestTag is unused.

Can you remove latestTag entirely

Move your workaround to commitCount instead, this is the property which is used

val commitCount by project.extra { if (!file(".git").exists()) return@extra 0

I think I misunderstood my error somehow. If I remove latestTag (like I have in my most recent commit), I don't get any errors at all. Below is the error latestTag was giving me:

Configuration cache problems found in this build. 1 problem was found storing the configuration cache. - Build file 'app/build.gradle.kts': failed to compute value with custom source 'org.gradle.api.internal.provider.sources.process.ProcessOutputValueSource' (output of the external process 'git') with org.gradle.process.ProcessExecutionException: Process 'command 'git'' finished with non-zero exit value 128 See the complete report at file:///home/jared/Repos/Feeder/build/reports/configuration-cache/2j05hzxg6syau6294zki64wh3/6iuaoko05omryjk13awau8is4/configuration-cache-report.html > Process 'command 'git'' finished with non-zero exit value 128 Ask Gemini

…mits content but doesn't have a modifier parameter'

bretthowell714-source

Thanks

spacecowboy · 2025-11-25T12:36:08Z

Thanks

@bretthowell714-source I am confused how you are assigning and approving PRs but please stop doing that

bretthowell714-source · 2025-11-25T12:56:24Z

I just started using GitHub I barely even know what I'm doing I'm trying to learn

bretthowell714-source · 2025-11-25T12:56:25Z

I just started using GitHub I barely even know what I'm doing I'm trying to learn

JaredTweed added 4 commits October 28, 2025 12:31

improved build process to make it easier

2731465

fixed build warnings

4d65856

included suggestions during search using json database

d34742a

updated feeds to only include working feeds (and more feeds) and incl…

fadc2b4

…uded script to check if feeds are working

JaredTweed changed the title ~~Improved build file~~ Improved build file & made search suggestions work when adding a feed Oct 28, 2025

updated suggested feeds

73c79be

spacecowboy changed the title ~~Improved build file & made search suggestions work when adding a feed~~ feat: added suggested feeds to the Search UI Oct 29, 2025

spacecowboy self-assigned this Oct 29, 2025

JaredTweed added 2 commits October 29, 2025 09:21

fixed how code backs out of adding a feed.

c030162

fixed memory leak

6482300

JaredTweed added 2 commits October 29, 2025 12:26

made suggested search results more concise by showing the feed url, b…

4e40258

…ut not the website

improved speed at which the python file cleans the feeds

1320371

spacecowboy self-requested a review October 30, 2025 15:46

JaredTweed added 6 commits October 30, 2025 17:06

made search use large substack database instead

3688377

made search show matches sorted by subscriber count

7f54e54

improved initial search lag

b7cea85

eliminated lag

1f51c5b

chose feeds_mapped better

b155253

java fix for build script but reverted the rest

6665ea5

reduced build file changes

690bb2b

JaredTweed added 2 commits October 31, 2025 09:43

updated feeds list

108eb1a

made build file better

b17f568

JaredTweed added 2 commits October 31, 2025 12:30

added file with the source of the feeds to update the list in the future

3d69a2a

if a feed link is in the format https://<feed>.substack.com/feed, onl…

5146e79

…y check if it matches the <feed> part during seach

spacecowboy requested changes Nov 2, 2025

View reviewed changes

JaredTweed added 2 commits November 2, 2025 07:43

removed latestTag and ran ./gradlew ktlintformat

a09f66f

fixed build fail with ./gradlew ktlintformat: '@composable function e…

eed93fa

…mits content but doesn't have a modifier parameter'

JaredTweed requested a review from spacecowboy November 2, 2025 14:19

spacecowboy approved these changes Nov 2, 2025

View reviewed changes

spacecowboy merged commit d00c572 into spacecowboy:master Nov 2, 2025
9 of 12 checks passed

bretthowell714-source approved these changes Nov 25, 2025

View reviewed changes

bretthowell714-source reviewed Nov 25, 2025

View reviewed changes

Uh oh!

Conversation

JaredTweed commented Oct 28, 2025

Uh oh!

spacecowboy commented Oct 29, 2025

Uh oh!

spacecowboy commented Oct 29, 2025

Uh oh!

JaredTweed commented Oct 29, 2025

Uh oh!

JaredTweed commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spacecowboy commented Oct 30, 2025

Uh oh!

spacecowboy commented Oct 30, 2025

Uh oh!

spacecowboy commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaredTweed commented Oct 30, 2025

Uh oh!

JaredTweed commented Oct 30, 2025

Uh oh!

JaredTweed commented Oct 31, 2025

Uh oh!

JaredTweed commented Oct 31, 2025

Uh oh!

spacecowboy commented Nov 2, 2025

Uh oh!

spacecowboy left a comment

Choose a reason for hiding this comment

Uh oh!

spacecowboy Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

JaredTweed Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bretthowell714-source left a comment

Choose a reason for hiding this comment

Uh oh!

spacecowboy commented Nov 25, 2025

Uh oh!

bretthowell714-source commented Nov 25, 2025

Uh oh!

bretthowell714-source commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JaredTweed commented Oct 29, 2025 •

edited

Loading

spacecowboy commented Oct 30, 2025 •

edited

Loading