fix: resolved flaky test caused by identical generated pubDates for undated feed items#1146
Merged
Conversation
…ndated feed items
… date generation - Replaced fallbackPubDate ZonedDateTime parameter with Clock injection in FeedItem.updateFromParsedEntry, making time controllable in tests - Updated RssLocalSync to pass Clock.fixed per item, with a comment explaining the reversed-order/fallback-timestamp relationship - Added JVM unit tests for updateFromParsedEntry date generation (no instrumentation needed): parsed date used when present, clock fallback when missing, existing date preserved, distinct clocks produce distinct dates - Improved assertion messages in feedWithNoDatesShouldGetSomeGenerated to clearly describe the feed-order-to-date-order expectation
jenningsloy318
pushed a commit
to jenningsloy318/Feeder
that referenced
this pull request
May 29, 2026
…ndated feed items (spacecowboy#1146) * fix: resolved flaky test caused by identical generated pubDates for undated feed items * refactor: injected Clock into updateFromParsedEntry for deterministic date generation - Replaced fallbackPubDate ZonedDateTime parameter with Clock injection in FeedItem.updateFromParsedEntry, making time controllable in tests - Updated RssLocalSync to pass Clock.fixed per item, with a comment explaining the reversed-order/fallback-timestamp relationship - Added JVM unit tests for updateFromParsedEntry date generation (no instrumentation needed): parsed date used when present, clock fallback when missing, existing date preserved, distinct clocks produce distinct dates - Improved assertion messages in feedWithNoDatesShouldGetSomeGenerated to clearly describe the feed-order-to-date-order expectation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.