feat: upgraded export format so saved articles can be imported again#1131
Conversation
|
Thanks for the PR @edd255 . I'm afraid this only solves a very small part of the overall feature. Consider the following:
At this point, the acceptance criteria is:
And a major obstacle to this is that the existing import does not contain enough information to fully resurrect the item in the database. All the metadata comes from the original feed entry which is no longer available, and Feeder's export is just of the link. To actually solve this, the exported data would need to be amended and contain the necessary metadata. |
|
Thanks for the feedback! :) I will take a look at this in a few days. This will break backwards-compatibility to some extent, as old exports cannot be imported then. But that seems like a reasonable trade-off. |
Not much to break. Existing exports of saved articles can't be imported at all. They only exist to allow people to extract their data. |
|
I built it and tested it on a real device. It should work now. Importing saved articles from feeds you are not subscribed to also works. |
spacecowboy
left a comment
There was a problem hiding this comment.
This is great @edd255 . Nice work!
I added a small nit-question inline
|
Thanks again @edd255 |
|
@spacecowboy Can you unblock translations on Weblate? |
Similarly to the user who created issue #913, I have noticed that Feeder is not able to import saved articles, which is a bit annoying when you switch devices. This PR should fix it. I have build this in Android Studio and tested it in a Google Pixel 9a emulator, and it seems to work.
Fixes #913