feat: use feed entry id as fallback link.#1144
Merged
spacecowboy merged 1 commit intoMay 19, 2026
Merged
Conversation
Some RSS feeds store entry links in the <id> field rather than in a separate <link> field. This change takes advantage of this by: 1. checking if <link> field is present. 2. if not, check if the <id> field is a valid HTTP/S URL, and if so use that as as the link.
Owner
|
thanks @fictiontoreality . Normally I'd say that we shouldn't cater to such incorrect feeds, but the code is clean and is covered by tests so 👍 |
jenningsloy318
pushed a commit
to jenningsloy318/Feeder
that referenced
this pull request
May 29, 2026
Some RSS feeds store entry links in the <id> field rather than in a separate <link> field. This change takes advantage of this by: 1. checking if <link> field is present. 2. if not, check if the <id> field is a valid HTTP/S URL, and if so use that as as the link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Some RSS feeds store entry links in the
<id>field rather than in a separate<link>field. Example: https://jacobin.com/feedThis change takes advantage of this by:
<link>field is present, use that as the link.<id>field is a valid absolute HTTP/S URL, and if so use that as the link.Checklist
./gradlew ktlintFormatand committed the resultMIGRATION_N_N+1inAppDatabase.ktapp/src/androidTest/.../db/room/Screenshots (if UI change)
N/A