refactor: cleaned up sync read-status layer#1142
Merged
Merged
Conversation
1. Moved ReadStatusSyncedDao.deleteReadStatusSyncs to RemoteReadMarkDao.deleteByIds. The old method deleted from remote_read_mark inside a DAO named ReadStatusSyncedDao, which was confusing and caused misdirection during bug investigation. Renamed the SyncRemoteStore wrapper to deleteAppliedRemoteReadMarks to reflect its actual purpose. 2. Removed two dead Flow query variants (getNextFeedItemWithoutSynced ReadMark, getFlowOfFeedItemsWithoutSyncedReadMark) from ReadStatusSyncedDao and SyncRemoteStore. Neither was called from any production code; only the plain-suspend getFeedItemsWithoutSyncedReadMark() is used. 3. Removed FeedItemDao.markAsRead(id: Long), which had byte-for-byte identical SQL to markAsReadAndNotified(id: Long) and was never called from any production code. 4. Made SyncRestClient.safeBlock's block parameter non-nullable and removed the dead if (block != null) guard. Every call site already passes a non-null lambda. 5. Renamed internal markAsRead(feedItems) to private sendReadMarksBatch(feedItems) to disambiguate it from the public markAsRead() coordinator. The old identical names made the call from coordinator to sender look like recursion.
jenningsloy318
pushed a commit
to jenningsloy318/Feeder
that referenced
this pull request
May 29, 2026
1. Moved ReadStatusSyncedDao.deleteReadStatusSyncs to RemoteReadMarkDao.deleteByIds. The old method deleted from remote_read_mark inside a DAO named ReadStatusSyncedDao, which was confusing and caused misdirection during bug investigation. Renamed the SyncRemoteStore wrapper to deleteAppliedRemoteReadMarks to reflect its actual purpose. 2. Removed two dead Flow query variants (getNextFeedItemWithoutSynced ReadMark, getFlowOfFeedItemsWithoutSyncedReadMark) from ReadStatusSyncedDao and SyncRemoteStore. Neither was called from any production code; only the plain-suspend getFeedItemsWithoutSyncedReadMark() is used. 3. Removed FeedItemDao.markAsRead(id: Long), which had byte-for-byte identical SQL to markAsReadAndNotified(id: Long) and was never called from any production code. 4. Made SyncRestClient.safeBlock's block parameter non-nullable and removed the dead if (block != null) guard. Every call site already passes a non-null lambda. 5. Renamed internal markAsRead(feedItems) to private sendReadMarksBatch(feedItems) to disambiguate it from the public markAsRead() coordinator. The old identical names made the call from coordinator to sender look like recursion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved ReadStatusSyncedDao.deleteReadStatusSyncs to RemoteReadMarkDao.deleteByIds. The old method deleted from remote_read_mark inside a DAO named ReadStatusSyncedDao, which was confusing and caused misdirection during bug investigation. Renamed the SyncRemoteStore wrapper to deleteAppliedRemoteReadMarks to reflect its actual purpose.
Removed two dead Flow query variants (getNextFeedItemWithoutSynced ReadMark, getFlowOfFeedItemsWithoutSyncedReadMark) from ReadStatusSyncedDao and SyncRemoteStore. Neither was called from any production code; only the plain-suspend getFeedItemsWithoutSyncedReadMark() is used.
Removed FeedItemDao.markAsRead(id: Long), which had byte-for-byte identical SQL to markAsReadAndNotified(id: Long) and was never called from any production code.
Made SyncRestClient.safeBlock's block parameter non-nullable and removed the dead if (block != null) guard. Every call site already passes a non-null lambda.
Renamed internal markAsRead(feedItems) to private sendReadMarksBatch(feedItems) to disambiguate it from the public markAsRead() coordinator. The old identical names made the call from coordinator to sender look like recursion.