fix: invisible SearchBar#1009
Merged
Merged
Conversation
I looked into issue spacecowboy#975 and traced the problem to how the SearchBar expansion state was being handled. Both the SearchBar and its inputField were configured with expanded = true. This appears to cause the SearchBar to start in an already-expanded state, which results in the search UI being present but not visibly rendered. Setting SearchBar(expanded = false) while leaving expansion controlled by the inputField restores the expected behavior: the SearchBar is visible in its collapsed state and expands correctly on interaction. This change only adjusts the initial expansion state and does not alter any search logic.
Owner
|
Thank you @luk-dushaj for fixing this! Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked into issue #975 and traced the problem to how the SearchBar expansion state was being handled.
Both the SearchBar and its inputField were configured with expanded = true. This appears to cause the SearchBar to start in an already-expanded state, which results in the search UI being present but not visibly rendered.
Setting SearchBar(expanded = false) while leaving expansion controlled by the inputField restores the expected behavior: the SearchBar is visible in its collapsed state and expands correctly on interaction.
This change only adjusts the initial expansion state and does not alter any search logic.
fixes #975