feat: add c api for proving sumcheck (PROOF-913)#245
Merged
Conversation
cbindings/sumcheck.t.cc
Outdated
| using namespace sxt; | ||
| using s25t::operator""_s25; | ||
|
|
||
| TEST_CASE("todo") { |
Contributor
There was a problem hiding this comment.
The TEST_CASE name is still "todo".
|
|
||
| using namespace sxt; | ||
|
|
||
| TEST_CASE("todo") {} |
Contributor
There was a problem hiding this comment.
Just double checking if you wanted to add tests with this PR, or is this a placeholder for future tests?
Contributor
Author
There was a problem hiding this comment.
Added a test. Thank you.
jacobtrombetta
approved these changes
Feb 14, 2025
|
🎉 This PR is included in version 1.109.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add C API for generating sumcheck proofs.
What changes are included in this PR?
Extend blitzar_api.h with a new function sxt_prove_sumcheck for creating sumcheck proofs.
Are these changes tested?
Yes.