Skip to content

Changes in style files structure and add !default to variables (fix #219)#221

Merged
jenssogaard merged 3 commits intospace10-community:developfrom
jorditarrida:develop
Feb 28, 2018
Merged

Changes in style files structure and add !default to variables (fix #219)#221
jenssogaard merged 3 commits intospace10-community:developfrom
jorditarrida:develop

Conversation

@jorditarrida
Copy link
Copy Markdown
Contributor

@jorditarrida jorditarrida commented Feb 12, 2018

These changes allow for SASS variables to be overriden. They also allow for easy SASS importing to other projects by just using the new main.scss file. The Gulp tasks have also been updated to reflect these changes.

@jorditarrida jorditarrida changed the title Changes in style files structure and add to variables (fix #219) Changes in style files structure and add !default to variables (fix #219) Feb 12, 2018
@jenssogaard
Copy link
Copy Markdown
Contributor

jenssogaard commented Feb 21, 2018

@jorditarrida I'm looking through and testing the PR now. Everything works as intended 🔥 💥 👍 .
One minor thing: I think it makes more sense to name main.scss --> ConversationalForm.scss to keep consistency with JS and naming throughout the rest of the project, agree?

Also, can you change CSS imports in the src/development*.html to reflect the single .css. Current:
`

`

to: <link type="text/css" rel="stylesheet" href="../build/main.css"/>

If that is fixed I believe we are ready to merge your PR and release an update along with a few other things in the works.

@jorditarrida
Copy link
Copy Markdown
Contributor Author

jorditarrida commented Feb 21, 2018

Hi,
I am renaming it to conversational-form.scss if you're OK with it (consistency with the naming in the generated dist/ folder). Will push in a few minutes.
Cheers,
Jordi

@jorditarrida
Copy link
Copy Markdown
Contributor Author

jorditarrida commented Feb 21, 2018

Done! Please do let me know if you need anything else.
Cheers,
Jordi

@jenssogaard
Copy link
Copy Markdown
Contributor

jenssogaard commented Feb 22, 2018

@jorditarrida awesome, thank you. I'm merging tonight and doing some other minor scss touch-ups while I'm at it.

@jenssogaard jenssogaard merged commit 1350a01 into space10-community:develop Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorditarrida @jenssogaard