Skip to content

Conversation

@GromNaN
Copy link

@GromNaN GromNaN commented Apr 1, 2025

Proposed implementation for symfony#60028

@soyuka soyuka force-pushed the allow-different-targets branch 8 times, most recently from 53b56d6 to 1910509 Compare April 2, 2025 14:05
@fabpot fabpot force-pushed the allow-different-targets branch from fd55ff0 to a5698aa Compare May 6, 2025 06:50
soyuka pushed a commit that referenced this pull request Jun 20, 2025
…he secret you are trying to reveal could not be decrypted (jack-worman)

This PR was submitted for the 7.4 branch but it was merged into the 7.2 branch instead.

Discussion
----------

[FrameworkBundle] Fixes getting a type error when the secret you are trying to reveal could not be decrypted

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Fixes getting a type error when the secret you are trying to reveal could not be decrypted.
```txt
In SymfonyStyle.php line 322:

  Symfony\Component\Console\Style\SymfonyStyle::writeln(): Argument #1 ($messages) must be of type Traversable|array|string, null given, called in /Users/jworman/PhpstormProjects/gtx/vendor/symfony/framework-bundle/Command/Sec
  retsRevealCommand.php on line 67

```

Not sure if this is considered a bug fix or a new feature

Commits
-------

480e7d1 Fix-type-error-when-revealing-broken-secret
soyuka pushed a commit that referenced this pull request Sep 12, 2025
…vice (a.dmitryuk)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[Cache] Make `TagAwareAdapter` registrable as a service

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Issues        | Fix symfony#59193 symfony#61114
| License       | MIT

Fixes error while registering TagAwareAdapter as a service:
```yaml
services:
  cache.adapter.array:
    class:  Symfony\Component\Cache\Adapter\ArrayAdapter
  cache.adapter.tag_aware_array:
    class: Symfony\Component\Cache\Adapter\TagAwareAdapter
    arguments:
      - '`@cache`.adapter.array'

framework:
    cache:
        pools:
            persistent.cache_pool:
                adapter: cache.adapter.tag_aware_array

```
```
TypeError: Symfony\Component\Cache\Adapter\TagAwareAdapter::__construct(): Argument #1 ($itemsPool) must be of type Symfony\Component\Cache\Adapter\AdapterInterface, string given, called in /var/www/var/cache/test/Container7bUFOLq/getPersistent_CachePoolService.php on line 28
```

Psalm failed unrelated

Commits
-------

d0a673d [Cache] Make `TagAwareAdapter` registrable as a service
soyuka pushed a commit that referenced this pull request Nov 13, 2025
…eout must be positive` (Jeroeny)

This PR was merged into the 6.4 branch.

Discussion
----------

[HttpClient] Fix `Warning: curl_multi_select(): timeout must be positive`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

Full error text: `ErrorException: Warning: curl_multi_select(): timeout must be between 0 and 2147484`

Somehow this timeout is a negative float in some cases. I haven't been able to reproduce it manually. Here's an example:

<img width="979" height="920" alt="image" src="https://github.com/user-attachments/assets/57e44026-cb1a-412c-acb2-b94ec13de48e" />

```
ErrorException: Warning: curl_multi_select(): timeout must be between 0 and 2147484
#0 /vendor/symfony/http-client/Response/CurlResponse.php(342): Symfony\Component\HttpClient\Response\CurlResponse::select
#1 /vendor/symfony/http-client/Response/TransportResponseTrait.php(298): Symfony\Component\HttpClient\Response\CurlResponse::stream
#2 /vendor/symfony/http-client/Response/CommonResponseTrait.php(148): Symfony\Component\HttpClient\Response\CurlResponse::initialize
symfony#3 /vendor/symfony/http-client/Response/TransportResponseTrait.php(130): Symfony\Component\HttpClient\Response\CurlResponse::doDestruct
symfony#4 /vendor/symfony/http-client/Response/CurlResponse.php(242): Symfony\Component\HttpClient\Response\CurlResponse::__destruct
symfony#5 /vendor/sentry/sentry/src/Client.php(177): Sentry\Client::captureEvent
symfony#6 /vendor/sentry/sentry/src/State/Hub.php(155): Sentry\State\Hub::captureEvent
symfony#7 /vendor/sentry/sentry/src/Tracing/Transaction.php(188): Sentry\Tracing\Transaction::finish
symfony#8 /vendor/..redacted(): ...::shutdownHandler
symfony#9 [internal](0)
```

Not sure if this is the place to enforce the `>=0` float or in https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/HttpClient/Response/CurlResponse.php#L363

Commits
-------

17eec0c Fix Warning: curl_multi_select(): timeout must be positive
soyuka pushed a commit that referenced this pull request Nov 20, 2025
…tion (xabbuh)

This PR was merged into the 7.4 branch.

Discussion
----------

[FrameworkBundle] fix routing config type information

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

tackling these issues reported by PHPStan:

```
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------
  Line   config/reference.php
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------
  1339   Parameter #1 $config (array{'when@dev'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?:
         string}}|array{path: array<string, string>|string, controller?: string, methods?: list<string>|string, requirements?: array<string, string>
         , defaults?: array<string, mixed>, options?: array<string, mixed>, host?: array<string, string>|string, schemes?: list<string>|string, ...}
         |array{resource: string, type?: string, exclude?: list<string>|string, prefix?: array<string, string>|string, name_prefix?: string, trailin
         g_slash_on_root?: bool, controller?: string, methods?: list<string>|string, ...}>, 'when@prod'?: array<string, array{alias: string, depreca
         ted?: array{package: string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, methods?: l
         ist<string>|string, requirements?: array<string, string>, defaults?: array<string, mixed>, options?: array<string, mixed>, host?: array<str
         ing, string>|string, schemes?: list<string>|string, ...}|array{resource: string, type?: string, exclude?: list<string>|string, prefix?: arr
         ay<string, string>|string, name_prefix?: string, trailing_slash_on_root?: bool, controller?: string, methods?: list<string>|string, ...}>,
         'when@test'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?: string}}|array{path: array<
         string, string>|string, controller?: string, methods?: list<string>|string, requirements?: array<string, string>, defaults?: array<string,
         mixed>, options?: array<string, mixed>, host?: array<string, string>|string, schemes?: list<string>|string, ...}|array{resource: string, ty
         pe?: string, exclude?: list<string>|string, prefix?: array<string, string>|string, name_prefix?: string, trailing_slash_on_root?: bool, con
         troller?: string, methods?: list<string>|string, ...}>}) of method Symfony\Component\Routing\Loader\Configurator\Routes::config() should be
          contravariant with parameter $config (array<string, array<string, array<int<0, max>|string, mixed>|bool|string>>) of method
         Symfony\Component\Routing\Loader\Configurator\RoutesReference::config()
         🪪  method.childParameterType
  1341   Method Symfony\Component\Routing\Loader\Configurator\Routes::config() should return array{'when@dev'?: array<string, array{alias: string,
         deprecated?: array{package: string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, meth
         ods?: list<string>|string, requirements?: array<string, string>, defaults?: array<string, mixed>, options?: array<string, mixed>, host?: ar
         ray<string, string>|string, schemes?: list<string>|string, ...}|array{resource: string, type?: string, exclude?: list<string>|string, prefi
         x?: array<string, string>|string, name_prefix?: string, trailing_slash_on_root?: bool, controller?: string, methods?: list<string>|string,
         ...}>, 'when@prod'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?: string}}|array{path:
         array<string, string>|string, controller?: string, methods?: list<string>|string, requirements?: array<string, string>, defaults?: array<st
         ring, mixed>, options?: array<string, mixed>, host?: array<string, string>|string, schemes?: list<string>|string, ...}|array{resource: stri
         ng, type?: string, exclude?: list<string>|string, prefix?: array<string, string>|string, name_prefix?: string, trailing_slash_on_root?: boo
         l, controller?: string, methods?: list<string>|string, ...}>, 'when@test'?: array<string, array{alias: string, deprecated?: array{package:
         string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, methods?: list<string>|string, r
         equirements?: array<string, string>, defaults?: array<string, mixed>, options?: array<string, mixed>, host?: array<string, string>|string,
         schemes?: list<string>|string, ...}|array{resource: string, type?: string, exclude?: list<string>|string, prefix?: array<string, string>|st
         ring, name_prefix?: string, trailing_slash_on_root?: bool, controller?: string, methods?: list<string>|string, ...}>} but returns array<str
         ing, array<string, array<int<0, max>|string, mixed>|bool|string>>.
         🪪  return.type
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------
 ```

Commits
-------

8147ee2 fix routing config type information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants