forked from symfony/symfony
-
Notifications
You must be signed in to change notification settings - Fork 0
[ObjectMapper] Provide the target object to the map condition #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GromNaN
wants to merge
3
commits into
soyuka:allow-different-targets
Choose a base branch
from
GromNaN:object-mapper-condition
base: allow-different-targets
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ObjectMapper] Provide the target object to the map condition #1
GromNaN
wants to merge
3
commits into
soyuka:allow-different-targets
from
GromNaN:object-mapper-condition
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add TargetClass condition
53b56d6 to
1910509
Compare
fd55ff0 to
a5698aa
Compare
soyuka
pushed a commit
that referenced
this pull request
Jun 20, 2025
…he secret you are trying to reveal could not be decrypted (jack-worman) This PR was submitted for the 7.4 branch but it was merged into the 7.2 branch instead. Discussion ---------- [FrameworkBundle] Fixes getting a type error when the secret you are trying to reveal could not be decrypted | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Fixes getting a type error when the secret you are trying to reveal could not be decrypted. ```txt In SymfonyStyle.php line 322: Symfony\Component\Console\Style\SymfonyStyle::writeln(): Argument #1 ($messages) must be of type Traversable|array|string, null given, called in /Users/jworman/PhpstormProjects/gtx/vendor/symfony/framework-bundle/Command/Sec retsRevealCommand.php on line 67 ``` Not sure if this is considered a bug fix or a new feature Commits ------- 480e7d1 Fix-type-error-when-revealing-broken-secret
soyuka
pushed a commit
that referenced
this pull request
Sep 12, 2025
…vice (a.dmitryuk) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Cache] Make `TagAwareAdapter` registrable as a service | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Issues | Fix symfony#59193 symfony#61114 | License | MIT Fixes error while registering TagAwareAdapter as a service: ```yaml services: cache.adapter.array: class: Symfony\Component\Cache\Adapter\ArrayAdapter cache.adapter.tag_aware_array: class: Symfony\Component\Cache\Adapter\TagAwareAdapter arguments: - '`@cache`.adapter.array' framework: cache: pools: persistent.cache_pool: adapter: cache.adapter.tag_aware_array ``` ``` TypeError: Symfony\Component\Cache\Adapter\TagAwareAdapter::__construct(): Argument #1 ($itemsPool) must be of type Symfony\Component\Cache\Adapter\AdapterInterface, string given, called in /var/www/var/cache/test/Container7bUFOLq/getPersistent_CachePoolService.php on line 28 ``` Psalm failed unrelated Commits ------- d0a673d [Cache] Make `TagAwareAdapter` registrable as a service
soyuka
pushed a commit
that referenced
this pull request
Nov 13, 2025
…eout must be positive` (Jeroeny) This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Fix `Warning: curl_multi_select(): timeout must be positive` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Full error text: `ErrorException: Warning: curl_multi_select(): timeout must be between 0 and 2147484` Somehow this timeout is a negative float in some cases. I haven't been able to reproduce it manually. Here's an example: <img width="979" height="920" alt="image" src="https://github.com/user-attachments/assets/57e44026-cb1a-412c-acb2-b94ec13de48e" /> ``` ErrorException: Warning: curl_multi_select(): timeout must be between 0 and 2147484 #0 /vendor/symfony/http-client/Response/CurlResponse.php(342): Symfony\Component\HttpClient\Response\CurlResponse::select #1 /vendor/symfony/http-client/Response/TransportResponseTrait.php(298): Symfony\Component\HttpClient\Response\CurlResponse::stream #2 /vendor/symfony/http-client/Response/CommonResponseTrait.php(148): Symfony\Component\HttpClient\Response\CurlResponse::initialize symfony#3 /vendor/symfony/http-client/Response/TransportResponseTrait.php(130): Symfony\Component\HttpClient\Response\CurlResponse::doDestruct symfony#4 /vendor/symfony/http-client/Response/CurlResponse.php(242): Symfony\Component\HttpClient\Response\CurlResponse::__destruct symfony#5 /vendor/sentry/sentry/src/Client.php(177): Sentry\Client::captureEvent symfony#6 /vendor/sentry/sentry/src/State/Hub.php(155): Sentry\State\Hub::captureEvent symfony#7 /vendor/sentry/sentry/src/Tracing/Transaction.php(188): Sentry\Tracing\Transaction::finish symfony#8 /vendor/..redacted(): ...::shutdownHandler symfony#9 [internal](0) ``` Not sure if this is the place to enforce the `>=0` float or in https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/HttpClient/Response/CurlResponse.php#L363 Commits ------- 17eec0c Fix Warning: curl_multi_select(): timeout must be positive
soyuka
pushed a commit
that referenced
this pull request
Nov 20, 2025
…tion (xabbuh) This PR was merged into the 7.4 branch. Discussion ---------- [FrameworkBundle] fix routing config type information | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT tackling these issues reported by PHPStan: ``` ------ --------------------------------------------------------------------------------------------------------------------------------------------- Line config/reference.php ------ --------------------------------------------------------------------------------------------------------------------------------------------- 1339 Parameter #1 $config (array{'when@dev'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, methods?: list<string>|string, requirements?: array<string, string> , defaults?: array<string, mixed>, options?: array<string, mixed>, host?: array<string, string>|string, schemes?: list<string>|string, ...} |array{resource: string, type?: string, exclude?: list<string>|string, prefix?: array<string, string>|string, name_prefix?: string, trailin g_slash_on_root?: bool, controller?: string, methods?: list<string>|string, ...}>, 'when@prod'?: array<string, array{alias: string, depreca ted?: array{package: string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, methods?: l ist<string>|string, requirements?: array<string, string>, defaults?: array<string, mixed>, options?: array<string, mixed>, host?: array<str ing, string>|string, schemes?: list<string>|string, ...}|array{resource: string, type?: string, exclude?: list<string>|string, prefix?: arr ay<string, string>|string, name_prefix?: string, trailing_slash_on_root?: bool, controller?: string, methods?: list<string>|string, ...}>, 'when@test'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?: string}}|array{path: array< string, string>|string, controller?: string, methods?: list<string>|string, requirements?: array<string, string>, defaults?: array<string, mixed>, options?: array<string, mixed>, host?: array<string, string>|string, schemes?: list<string>|string, ...}|array{resource: string, ty pe?: string, exclude?: list<string>|string, prefix?: array<string, string>|string, name_prefix?: string, trailing_slash_on_root?: bool, con troller?: string, methods?: list<string>|string, ...}>}) of method Symfony\Component\Routing\Loader\Configurator\Routes::config() should be contravariant with parameter $config (array<string, array<string, array<int<0, max>|string, mixed>|bool|string>>) of method Symfony\Component\Routing\Loader\Configurator\RoutesReference::config() 🪪 method.childParameterType 1341 Method Symfony\Component\Routing\Loader\Configurator\Routes::config() should return array{'when@dev'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, meth ods?: list<string>|string, requirements?: array<string, string>, defaults?: array<string, mixed>, options?: array<string, mixed>, host?: ar ray<string, string>|string, schemes?: list<string>|string, ...}|array{resource: string, type?: string, exclude?: list<string>|string, prefi x?: array<string, string>|string, name_prefix?: string, trailing_slash_on_root?: bool, controller?: string, methods?: list<string>|string, ...}>, 'when@prod'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, methods?: list<string>|string, requirements?: array<string, string>, defaults?: array<st ring, mixed>, options?: array<string, mixed>, host?: array<string, string>|string, schemes?: list<string>|string, ...}|array{resource: stri ng, type?: string, exclude?: list<string>|string, prefix?: array<string, string>|string, name_prefix?: string, trailing_slash_on_root?: boo l, controller?: string, methods?: list<string>|string, ...}>, 'when@test'?: array<string, array{alias: string, deprecated?: array{package: string, version: string, message?: string}}|array{path: array<string, string>|string, controller?: string, methods?: list<string>|string, r equirements?: array<string, string>, defaults?: array<string, mixed>, options?: array<string, mixed>, host?: array<string, string>|string, schemes?: list<string>|string, ...}|array{resource: string, type?: string, exclude?: list<string>|string, prefix?: array<string, string>|st ring, name_prefix?: string, trailing_slash_on_root?: bool, controller?: string, methods?: list<string>|string, ...}>} but returns array<str ing, array<string, array<int<0, max>|string, mixed>|bool|string>>. 🪪 return.type ------ --------------------------------------------------------------------------------------------------------------------------------------------- ``` Commits ------- 8147ee2 fix routing config type information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed implementation for symfony#60028