Remove instance location information from the inspect command
#597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Cruz Viotti <[email protected]>
🤖 Augment PR SummarySummary: This PR removes instance-location reporting from the Changes:
Technical Notes: The core framing code now focuses on locations/references only, reducing compute/memory previously used to derive unresolved instance locations. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| // Skip entries that have direct references pointing to them | ||
| const auto entry_pointer{ | ||
| location.relative_pointer.concat({"allOf", index - 1})}; |
There was a problem hiding this comment.
SchemaFrame::references_to() compares against Location.pointer (root pointer), but this check builds entry_pointer from location.relative_pointer. If the schema has nested $id/base changes, relative_pointer can differ from the root pointer and this may miss existing references to an allOf branch, allowing an unsafe elevation.
🤖 Was this useful? React with 👍 or 👎
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 9, 2026
⚠️ **CAUTION: this is a major update, indicating a breaking change!**⚠️ This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | major | `v13.6.0` → `v14.0.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary> ### [`v14.0.2`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.0.2) [Compare Source](sourcemeta/jsonschema@v14.0.1...v14.0.2) #### What's Changed - feat: order lint errors by line number by [@​Karan-Palan](https://github.com/Karan-Palan) in [#​599](sourcemeta/jsonschema#599) **Full Changelog**: <sourcemeta/jsonschema@v14.0.1...v14.0.2> ### [`v14.0.1`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.0.1) [Compare Source](sourcemeta/jsonschema@v14.0.0...v14.0.1) #### What's Changed - Use an array of bytes for `compile --include` by [@​jviotti](https://github.com/jviotti) in [#​598](sourcemeta/jsonschema#598) **Full Changelog**: <sourcemeta/jsonschema@v14.0.0...v14.0.1> ### [`v14.0.0`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.0.0) [Compare Source](sourcemeta/jsonschema@v13.6.0...v14.0.0) #### What's Changed - Better detect unreferenced definitions in the linter by [@​jviotti](https://github.com/jviotti) in [#​595](sourcemeta/jsonschema#595) - Generate C/C++ headers in `compile` using `--include` (like `xxd`) by [@​jviotti](https://github.com/jviotti) in [#​596](sourcemeta/jsonschema#596) - Remove instance location information from the `inspect` command by [@​jviotti](https://github.com/jviotti) in [#​597](sourcemeta/jsonschema#597) **Full Changelog**: <sourcemeta/jsonschema@v13.6.0...v14.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuNjkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1ham9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]