This repository was archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: restart alerts for services w/o 0-downtime deploys #17299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
force-pushed
the
container-restart-zerodowntime
branch
from
07df01b to
52e9e53
Compare
|
Notifying subscribers in CODENOTIFY files for diff 57098f2...52e9e53.
|
Codecov Report
@@ Coverage Diff @@
## main #17299 +/- ##
=======================================
Coverage 52.15% 52.15%
=======================================
Files 1712 1712
Lines 85398 85398
Branches 7605 7548 -57
=======================================
+ Hits 44537 44539 +2
+ Misses 36954 36950 -4
- Partials 3907 3909 +2
|
keegancsmith
approved these changes
Jan 15, 2021
I don't think we can do dynamic thresholds without a bit of work (update how the thresholds are drawn, etc), and I'm not sure if there's a great way to reliably count replicas for a service across deployment types just from metrics I'll leave that as some possible future work, will merge this for now because it is currently paging |
bobheadxi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working container restart alerts were recently added for Kubernetes deployments as part of https://github.com/sourcegraph/sourcegraph/pull/17239
However, it seems that periods of container restarts during deployments are expected for certain services. This change removes the critical alert and warn on extended restarts instead.