Fixes for issues highlighted in #175 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was
linked to
issues
Aug 11, 2025
Owner
|
Thanks for submitting this, your help is greatly appreciated. I'll spend some time now running some tests. |
Owner
|
Sent about 50 emails through this and it's working fine for my tests. Nice one @DanielHudson2 thanks for your contribution! I'll push this through as a patch release and hopefully get it back listed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue here #175
Reviewed and implemented fixes based on feedback from plugin review, also validated fixes using https://wordpress.org/plugins/plugin-check/
register_setting()#178 fixed by adding a helper function that sanitises each field in the settings array in src/settings/class-settings.php and calling on instances ofregister_settingwhere needed