Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: address boundary error #2408

Closed
ceclin opened this issue Mar 13, 2023 · 2 comments · Fixed by #2417
Closed

Parser: address boundary error #2408

ceclin opened this issue Mar 13, 2023 · 2 comments · Fixed by #2417
Assignees
@quentin
Labels
bug - identified Bugs with an identified cause

Comments

@ceclin
Copy link

ceclin commented Mar 13, 2023

I currently use the latest release (2.4), which is installed on windows wsl2 (ubuntu) following the installation guide.

Address boundary error occurs if input is a file with following content:

x

Example:

> souffle x.dl
Error: syntax error, unexpected end of file, expecting ( or . in 
fish: Job 1, 'souffle x.dl' terminated by signal SIGSEGV (Address boundary error)
@ceclin
Copy link
Author

ceclin commented Mar 13, 2023

I tried some debugging. Here is something that may be helpful.
(I am not sure since I am new to souffle's source code)

souffle/src/parser/scanner.ll

Lines 411 to 417 in b60c8e9

<<EOF>> {
yypop_buffer_state(yyscanner);
yyinfo.pop();
if (!YY_CURRENT_BUFFER) {
return yy::parser::make_END(yylloc);
}
}

yylloc.file is empty after yyinfo.pop();

A possible patch:

souffle/src/parser/SrcLocation.cpp

Lines 142 to 144 in b60c8e9

Frames.push(yylloc);
yylloc.file = NewFile;
yylloc.start = yylloc.end = {1, 1}; 

    if (yylloc.file) Frames.push(yylloc);
    yylloc.file = NewFile;
    yylloc.start = yylloc.end = {1, 1};

@quentin quentin added the bug - identified Bugs with an identified cause label Jun 17, 2023
@quentin quentin self-assigned this Jun 17, 2023
@quentin
Copy link
Member

quentin commented Jun 17, 2023

The root cause is that we pop the last valid context frame before creating the last token, hence yylloc is the empty location.

quentin added a commit to quentin/souffle that referenced this issue Jun 17, 2023
@quentin
fix bad source location for END token
0813e52 
Fixes souffle-lang#2408
@quentin quentin mentioned this issue Jun 17, 2023
Merged
quentin added a commit that referenced this issue Jun 23, 2023
@quentin
fix bad source location for END token (#2417)
8fc94d2 
Fixes #2408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quentin quentin

Labels
bug - identified Bugs with an identified cause
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bad source location for END token quentin/souffle
2 participants
@quentin @ceclin